Skip to content

fix: end the course with a timer stop_all event at the last record - #43

Open
haraldh wants to merge 1 commit into
masterfrom
haraldh/fit-stop-all-event
Open

haraldh wants to merge 1 commit into
masterfrom
haraldh/fit-stop-all-event

Conversation

@haraldh

@haraldh haraldh commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Aligns one detail of the written FIT course with Garmin's reference, EncodeCourse.java:

  • The closing timer event is now EventType.STOP_ALL instead of STOP_DISABLE_ALL.
  • It carries the timestamp of the last written record. Before, it used the last track point's timestamp, which differs when that point is dropped for being too close to the previous record.

TestCourseFit.courseEndsWithTimerStopAllAtTheLastRecord decodes the written FIT and checks the last event.

This changes what devices receive. Test it on a real Garmin device before merging.

🤖 Generated with Claude Code

Garmin's EncodeCourse example ends a course with a timer event of type
STOP_ALL; gexporter wrote STOP_DISABLE_ALL. The event now also carries
the timestamp of the last written record instead of the last track
point, which can differ when that point is dropped as too close to the
previous record.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant