Repository navigation
fix: multiple Garmin devices, Locus route timestamps, waypoint distances - #38
Merged
Merged
Conversation
… that has it Each connected device reported its own result, and the last one to answer won: a watch without gimporter showed "not installed" although the Edge next to it had the app. The best result of all devices is shown now. Fixes #15 Fixes gimportexportdevs/gimporter#14
- Locus Map writes route times relative to 1970-01-01. Since the time
parser handles fractional seconds (20.1.0), these times reached the FIT
file as they are, before the FIT epoch; the Edge opened the course but
rejected it once saved ("invalid course"). Times before the FIT epoch
are now moved so the course starts at it, keeping the durations.
- GPX waypoints became course points without a distance, so devices showed
them all at the end of the course in "Up Ahead". Each now takes the
distance and timestamp of the nearest track point, in course order.
- A waypoint without <type> crashed the conversion (CoursePoint.valueOf
with null).
TestCourseFit decodes the written FIT to check both.
Fixes #36
Fixes #14
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes from the open issues.
<type>crashed the conversion (CoursePoint.valueOf(null)).TestCourseFitdecodes the written FIT and checks distances and timestamps; 2 of its 3 tests fail without the fix. All 73 unit tests pass.Fixes #15
Fixes #36
Fixes #14
🤖 Generated with Claude Code