Skip to content

feat: Immediately delete completed tasks#724

Merged
evanh merged 2 commits into
mainfrom
evanh/feat/delete-completed-tasks-immediately
Jun 19, 2026
Merged

feat: Immediately delete completed tasks#724
evanh merged 2 commits into
mainfrom
evanh/feat/delete-completed-tasks-immediately

Conversation

@evanh

@evanh evanh commented Jun 19, 2026

Copy link
Copy Markdown
Member

Previously activations that completed successfully would have their status updated, and then the upkeep thread would remove all the completed activations in batches. Now that the status update is happening in batches, the completed activations can also be immediately deleted instead of waiting for the upkeep thread.

Previously activations that completed successfully would have their status updated, and then the upkeep
thread would remove all the completed activations in batches. Now that the status update is happening in
batches, the completed activations can also be immediately deleted instead of waiting for the upkeep
thread.
@evanh evanh requested a review from a team as a code owner June 19, 2026 13:58

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cf221e3. Configure here.

Comment thread src/grpc/server.rs Outdated

@untitaker untitaker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my understanding, the upkeep thread also used to batch deletes, right?

is it planned to remove some stuff from upkeep in a later change?

Comment thread src/grpc/server.rs Outdated
@evanh

evanh commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

for my understanding, the upkeep thread also used to batch deletes, right?

is it planned to remove some stuff from upkeep in a later change?

No, because the upkeep thread itself also moves things to "Completed". After it handles some errors states it will mark the task as completed and then delete it. The expectation though is that there are a lot less things being deleted by the upkeep thread.

Comment thread src/grpc/server.rs
@evanh evanh merged commit b203775 into main Jun 19, 2026
26 checks passed
@evanh evanh deleted the evanh/feat/delete-completed-tasks-immediately branch June 19, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants