Skip to content

Prioritize pruning system frames#2592

Merged
dcramer merged 1 commit intomasterfrom
improve-stacktrace-slimming
Jan 25, 2016
Merged

Prioritize pruning system frames#2592
dcramer merged 1 commit intomasterfrom
improve-stacktrace-slimming

Conversation

@dcramer
Copy link
Copy Markdown
Member

@dcramer dcramer commented Jan 24, 2016

This changes the logic in frame trimming to go over system frames first, as they're likely less valuable.

@codecov-io
Copy link
Copy Markdown

Current coverage is 82.58%

Merging #2592 into master will decrease coverage by -0.47% as of 4c1003b

@@            master   #2592   diff @@
======================================
  Files          861     861       
  Stmts        32461   32476    +15
  Branches         0       0       
  Methods          0               
======================================
- Hit          26960   26821   -139
  Partial          0       0       
- Missed        5501    5655   +154

Review entire Coverage Diff as of 4c1003b


Uncovered Suggestions

  1. +0.07% via ...try/utils/apidocs.py#414...436
  2. +0.07% via ...try/utils/apidocs.py#117...139
  3. +0.07% via ...gs/sentry_helpers.py#191...211
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@mattrobenolt
Copy link
Copy Markdown
Contributor

These are going to need to be coordinated, right? getsentry/raven-python#691

Otherwise we may be stripping too much if the client and server aren't agreed on the exact algorithm.

@dcramer
Copy link
Copy Markdown
Member Author

dcramer commented Jan 25, 2016

Im not too worried about coordinating this. The goal of stripping is just to ensure its manageable, and if we're already stripping items that are useful, this wont make it worse (given that its prioritizing app frames).

dcramer added a commit that referenced this pull request Jan 25, 2016
@dcramer dcramer merged commit cc71e0b into master Jan 25, 2016
@dcramer dcramer deleted the improve-stacktrace-slimming branch January 25, 2016 16:58
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants