feat(preprod): Read app icons from the size-analysis usecase - #124328
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
NicoHinderling
marked this pull request as ready for review
September 14, 2026 19:33
NicoHinderling
force-pushed
the
feat/size-analysis-objectstore-usecase
branch
from
September 14, 2026 21:06
8bf7418 to
1220e9b
Compare
NicoHinderling
changed the base branch from
master
to
feat/snapshots-objectstore-usecase
September 14, 2026 21:06
NicoHinderling
commented
Sep 14, 2026
| # TODO: On January 1, 2027, remove the preprod fallback for app icons. | ||
| result = get_session(UsecaseId.PREPROD, project).get(object_key) | ||
| else: | ||
| result = get_snapshot_storage(project).get(object_key) |
Contributor
Author
There was a problem hiding this comment.
this it a little unintuitive but get_snapshot_storage will first check the preprod_snapshots use case and if it's not there it will fall back to preprod
so between this completing deployment and the frontend one not out yet , app icon requests will go through get_snapshot_storage but will still work thanks to this fallback
once the FE PR deploys, it will specify is_app_icon and those size requests wont go through get_snapshot_storage anymore
rbro112
reviewed
Sep 14, 2026
| @@ -90,6 +90,7 @@ class UsecaseId(Enum): | |||
| PROFILE_ATTACHMENTS = "profile_attachments" | |||
| PREPROD = "preprod" | |||
Member
There was a problem hiding this comment.
Might be good to add a #Deprecated comment on this one just to make sure people/agents don't accidentally use it
rbro112
reviewed
Sep 14, 2026
| if is_app_icon: | ||
| result = get_session(UsecaseId.PREPROD_SIZE, project).get(object_key) | ||
| if result is None: | ||
| # TODO: On January 1, 2027, remove the preprod fallback for app icons. |
Member
There was a problem hiding this comment.
I'd add a metric and/or log here to let us know how often this is being set as PREPROD so we can have insight into this when we remove
Also track in linear so we don't forget to delete it 😉
Contributor
Author
There was a problem hiding this comment.
rbro112
approved these changes
Sep 14, 2026
Base automatically changed from
feat/snapshots-objectstore-usecase
to
master
September 14, 2026 22:33
Track completed size-icon and snapshot fallback reads by outcome for the health dashboard. Mark the shared preprod usecase deprecated while preserving migration compatibility. Refs EME-1313
NicoHinderling
force-pushed
the
feat/size-analysis-objectstore-usecase
branch
from
September 14, 2026 22:38
e2ab7e5 to
c4cf5e6
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
NicoHinderling
enabled auto-merge (squash)
September 14, 2026 22:44
NicoHinderling
added a commit
that referenced
this pull request
Sep 15, 2026
…4330) Makes the shared image endpoint's request type explicit throughout the preprod UI. App icons send `image_type=preprod_size_app_icon`; snapshot screenshots and diff masks send `image_type=preprod_snapshots`. Snapshot URL construction is shared across the normal image helper and both diff-mask render paths, while preserving the encoded `filename` parameter used by Save Image As. Backend support is stacked as #124194 → #124328 and should deploy first. The endpoint uses the shared snapshot reader for snapshots and untyped legacy requests, and a separate size-icon reader for `preprod_size_app_icon`; it never interprets image-ID prefixes. Deploy this frontend before getsentry/launchpad#684 switches app-icon writes. Cached clients that omit `image_type` can still miss icons stored only in `preprod_size` until refreshed. This PR changes only frontend requests, not storage or retention policies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
UsecaseId.PREPROD_SIZE(preprod_size) and explicitimage_typehandling in the shared image endpoint. Uses the shared snapshot reader introduced by #124194, now onmaster.preprod_size_app_icon: readpreprod_size, thenpreprodif missing.preprod_snapshots: delegate toget_snapshot_storage, preserving its two-namespace reader.image_type: use the shared snapshot reader for legacy requests. IDs remain opaque; no prefix selects a reader.The independent #124210 controls the snapshot reader's primary/write usecase. The reader defaults to
preprodfirst; when that option is enabled, it triespreprod_snapshotsfirst and falls back topreprod. This PR neither enables that option nor resolves its outstanding rollout blocker.Both size-icon fallback reads and snapshot GET/HEAD fallback reads emit
preprod.objectstore.fallbacklogs with the reader'simage_type,operation, andfoundresult for the Preprod Health dashboard. The logs count completed secondary reads, not primary hits or storage errors; the snapshot secondary namespace depends on the write option. MarksUsecaseId.PREPRODdeprecated for new code while retaining migration compatibility. Cleanup is tracked in EME-1313, and both January 1, 2027 TODOs remain.Companion frontend: #124330. Companion writer: getsentry/launchpad#684. Confirm the Objectstore expiration safeguards from getsentry/ops#23486 are deployed, deploy the shared reader and this backend change, then deploy the frontend before switching Launchpad writes. Cached clients that omit
image_typecan still miss icons stored only inpreprod_sizeuntil refreshed; the default reader does not infer icon type from IDs.