Skip to content

ref(autofix): Gate manual PR iteration UI behind its own feature flag - #121189

Merged
alexsohn1126 merged 1 commit into
alexsohn/cw-1778/disable-manual-pr-iteration-by-another-feature-flag-backendfrom
alexsohn/cw-1778/disable-manual-pr-iteration-by-another-feature-flag-frontend
Aug 4, 2026
Merged

ref(autofix): Gate manual PR iteration UI behind its own feature flag#121189
alexsohn1126 merged 1 commit into
alexsohn/cw-1778/disable-manual-pr-iteration-by-another-feature-flag-backendfrom
alexsohn/cw-1778/disable-manual-pr-iteration-by-another-feature-flag-frontend

Conversation

@alexsohn1126

@alexsohn1126 alexsohn1126 commented Aug 4, 2026

Copy link
Copy Markdown
Member

Frontend half of CW-1778. Depends on #121180 (backend) for the new flag registration — land that first.

autofix-pr-iteration gates both manual and automated CI PR iteration, so automated CI iteration can't ship without also exposing the manual UI. The backend PR added organizations:autofix-pr-iteration-manual; this moves the user-driven affordances onto it.

current ui when manual feature flag is of -- you can still see the automatic iterations in the form of feedback, but we removed the form to trigger the iteration with a manual feedback.

image

with the manual flag -- show manual feedback form again:

image

Fixes CW-1778

@linear-code

linear-code Bot commented Aug 4, 2026

Copy link
Copy Markdown

CW-1778

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 4, 2026
@alexsohn1126
alexsohn1126 changed the base branch from master to alexsohn/cw-1778/disable-manual-pr-iteration-by-another-feature-flag-backend August 4, 2026 17:23
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Story previews

Preview the stories changed in this PR on the Vercel deployment:

Preview deployment: https://sentry-7zq175wys.sentry.dev

@alexsohn1126
alexsohn1126 force-pushed the alexsohn/cw-1778/disable-manual-pr-iteration-by-another-feature-flag-frontend branch from 1653977 to d1c5d99 Compare August 4, 2026 17:24
@sentry

sentry Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 451 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

Frontend half of CW-1778, following the backend split. Only the affordances
a user drives move to `autofix-pr-iteration-manual`:

- `isRunValidForPrIteration`, which gates the feedback form in the
  pull-request next step
- the feedback form and its reset behavior in the code changes card

Iteration *reporting* is shared with automated CI iteration and accepts
either flag: the "Iterating on PR…" progress copy, the feedback history,
the version tag, and PR polling in the drawer (automated CI iteration
pushes commits with no user action, so the drawer must still poll).

`isResetEligible` is a behavior change, not just visibility: reset stays
available once a PR exists only where reset opens the manual form, so
automated-CI-only orgs keep the pre-iteration behavior. Both directions are
now covered, verified by mutation.
@alexsohn1126
alexsohn1126 force-pushed the alexsohn/cw-1778/disable-manual-pr-iteration-by-another-feature-flag-frontend branch from d1c5d99 to 45e1c32 Compare August 4, 2026 17:47
@alexsohn1126
alexsohn1126 marked this pull request as ready for review August 4, 2026 18:19
@alexsohn1126
alexsohn1126 requested review from a team as code owners August 4, 2026 18:19
Comment thread static/app/components/events/autofix/v3/codeChangesCard.tsx

@joseph-sentry joseph-sentry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i could see a way where we land the frontend change first since if we roll out the BE first we show the form in the FE still until we roll out the FE change and the form fails because the BE rejects that request bc the flag is not enabled

it's fine here bc this feature is still internal and not used heavily

@alexsohn1126
alexsohn1126 merged commit 81b17f4 into master Aug 4, 2026
78 of 107 checks passed
@alexsohn1126
alexsohn1126 deleted the alexsohn/cw-1778/disable-manual-pr-iteration-by-another-feature-flag-frontend branch August 4, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants