ref(tables): wrap SimpleTable error states in SimpleTable.Empty - #121176
Open
JoshuaKGoldberg wants to merge 1 commit into
Open
ref(tables): wrap SimpleTable error states in SimpleTable.Empty#121176JoshuaKGoldberg wants to merge 1 commit into
JoshuaKGoldberg wants to merge 1 commit into
Conversation
`SimpleTable` renders its children directly into the table's grid, so a bare `<LoadingError />` sibling lands in the column tracks rather than spanning the row like the empty state next to it already does. Wraps the error branches in `SimpleTable.Empty`, matching what each of these tables already does for its empty branch. Ref DE-1392
github-actions
Bot
added
the
Scope: Frontend
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
marked this pull request as ready for review
August 4, 2026 16:39
natemoo-re
approved these changes
Aug 4, 2026
ryan953
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleTablerenders its children directly into the table's grid, so a bare<LoadingError />sibling lands in the column tracks rather than spanning the row. This wraps the error branches inSimpleTable.Emptyso both status states span the row.Split out of #120745, as part of DE-1392. See that PR for the full end state.