ref(grouping): Remove Python enhancement executor - #121174
Open
scttcper wants to merge 1 commit into
Open
Conversation
Enhancement execution has been Rust-only since the rollout cleanup, but parser objects still carried the old Python matcher and action machinery. Remove that dead path and its legacy tests while keeping config parsing, serialization, Rust inputs, and hint attribution unchanged. Make split action flags lazy as well so cached configs do not recompute state they never read. Co-Authored-By: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Backend
scttcper
changed the title
scttcper
marked this pull request as ready for review
August 4, 2026 16:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement execution moved fully to Rust in #67778, but the Python rule objects still carried the old matcher and action executor. Remove that dead implementation and the tests dedicated to it, finishing the cleanup started in #67680.
EnhancementRuleremains the Python representation used for parsing, splitting classifier and contribution rules, base64 serialization, and hint attribution. Its classification flags are now lazy, avoiding unused work when loading already-split base64 configs.This improves
grouping.enhancements.creationfor projects with custom or derived rules. The default config has no local rules and remains within benchmark noise.Warm config-load benchmark, median of 7 runs with 1,000 loads per run: