test(ourlogs): unmark stale flaky markers in logsTableRow tests - #120847
Merged
JoshuaKGoldberg merged 4 commits intoJul 31, 2026
Merged
Conversation
usePrefetchTraceItemDetailsOnHover scheduled a trace-item prefetch on hover start and cleared it only on hover end, so a row that unmounted while its timer was pending still fired the request. In the app that is a wasted fetch after the table is gone; in Jest the timer outlives test cleanup and lands in a later test, which fails on an unmocked /trace-items/{id}/ request.
The hook now tracks the timer it scheduled and clears it on unmount, only releasing the shared ref when the pending timer is its own so an unmounting row cannot cancel a sibling's prefetch. This also drops the trace-item mocks added to logsInfiniteTable.spec.tsx to absorb the leaked requests.
Refs LOGS-936
All seven it.isKnownFlake() markers in this file came from one automated batch on 2026-06-03, generated from CI data collected before the underlying failures were fixed on 2026-05-28 by #116374, #116405, and #114893. The automation never revisits markers, so they have sat here for two months. Every CI issue Sentry recorded for this file is resolved, and the only event in the last 90 days came from an experimental React-compiler branch rather than master. Local runs are clean: 1436 executions under the 50x stress harness, including four concurrent runs to force CPU contention, plus simulated response latency up to 500ms. The marker is a no-op in normal CI, expanding to 50 runs only when the Frontend: Rerun Flaky Tests label sets RERUN_KNOWN_FLAKY_TESTS. Removing it changes no default CI behavior; it stops advertising these tests as flaky. Refs LOGS-936
github-actions
Bot
added
the
Scope: Frontend
Base automatically changed from
joshgoldberg/logs-936-fix-flakiness-in-logsinfinitetablespectsx
to
master
July 30, 2026 12:39
…ogs-table-row-tests
scttcper
approved these changes
Jul 31, 2026
JoshuaKGoldberg
deleted the
joshgoldberg/logs-936-unmark-stale-flaky-logs-table-row-tests
branch
July 31, 2026 16:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the seven
it.isKnownFlake()markers inlogsTableRow.spec.tsx. They are stale: the flakes they describe were fixed two months ago, but nothing removes markers once the automation adds them.Timeline:
LogFixtureMeta is not a function,toMatchObject,toHaveBeenCalledTimes).Follow-up to LOGS-936