Skip to content

feat(types): Add Unit enum#1072

Merged
szokeasaurusrex merged 1 commit into
masterfrom
szokeasaurusrex/metrics-units
Apr 28, 2026
Merged

feat(types): Add Unit enum#1072
szokeasaurusrex merged 1 commit into
masterfrom
szokeasaurusrex/metrics-units

Conversation

@szokeasaurusrex
Copy link
Copy Markdown
Member

The Unit enum will be used in the Metric type to store metric units.

Closes #1070
Closes RUST-192

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 21, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6e87503

@szokeasaurusrex szokeasaurusrex marked this pull request as draft April 21, 2026 12:31
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-units branch from 3653ee7 to 9f45f55 Compare April 21, 2026 12:32
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review April 21, 2026 12:32
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-units branch from 9f45f55 to e92d0c8 Compare April 21, 2026 12:34
Copy link
Copy Markdown
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-units branch from e92d0c8 to 75ee89b Compare April 22, 2026 09:14
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-units branch from 75ee89b to 1af4f9d Compare April 28, 2026 09:22
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1af4f9d. Configure here.

Comment thread sentry-types/src/protocol/unit.rs
The `Unit` enum will be used in the `Metric` type to store metric units.

Closes #1070
Closes [RUST-192](https://linear.app/getsentry/issue/RUST-192/add-unit-constantsenum)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-units branch from 1af4f9d to 6e87503 Compare April 28, 2026 12:38
@szokeasaurusrex szokeasaurusrex merged commit 6e87503 into master Apr 28, 2026
24 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/metrics-units branch April 28, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Unit constants/enum

3 participants