Skip to content

feat(metrics): Add metric user attributes from scope#1063

Merged
szokeasaurusrex merged 1 commit intomasterfrom
szokeasaurusrex/user-attributes-metrics
Apr 28, 2026
Merged

feat(metrics): Add metric user attributes from scope#1063
szokeasaurusrex merged 1 commit intomasterfrom
szokeasaurusrex/user-attributes-metrics

Conversation

@szokeasaurusrex
Copy link
Copy Markdown
Member

@szokeasaurusrex szokeasaurusrex commented Apr 16, 2026 •
edited
Loading

Add the metric user attribute portion of the earlier enrichment work.

Pass send_default_pii into metric scope application and attach user.id, user.name, and user.email from the scope when that option is enabled. Preserve explicitly set user.* metric attributes instead of overwriting them.

Stacked on #1062

Co-authored-by: Joris Bayer joris.bayer@sentry.io
Closes #1060
Closes RUST-188

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 16, 2026

RUST-188 Add trace metric user attribute enrichment gated by send_default_pii in sentry-core

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3c4abb6

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-defaults-scoped branch from efcf784 to 8a5dd6f Compare April 16, 2026 19:48
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/user-attributes-metrics branch from 3ab9f68 to 948a361 Compare April 16, 2026 19:48
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review April 16, 2026 19:57
@szokeasaurusrex szokeasaurusrex requested a review from lcian as a code owner April 16, 2026 19:57
lcian
lcian reviewed Apr 17, 2026
View reviewed changes
Comment thread sentry-core/src/scope/real.rs
lcian
lcian approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

szokeasaurusrex added a commit that referenced this pull request Apr 21, 2026
@szokeasaurusrex @jjbayer
feat(metrics): Add metric user attributes from scope (#1063)
aa6f863 
Add the metric user attribute portion of the earlier enrichment work.

Pass send_default_pii into metric scope application and attach user.id, user.name, and user.email from the scope when that option is enabled. Preserve explicitly set `user.*` metric attributes instead of overwriting them.

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Closes #1060
Closes [RUST-188](https://linear.app/getsentry/issue/RUST-188/add-trace-metric-user-attribute-enrichment-gated-by-send-default-pii)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-defaults-scoped branch from 8a5dd6f to 2b6b592 Compare April 21, 2026 12:40
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/user-attributes-metrics branch from 948a361 to aa6f863 Compare April 21, 2026 12:41
szokeasaurusrex added a commit that referenced this pull request Apr 21, 2026
@szokeasaurusrex @jjbayer
feat(metrics): Add metric user attributes from scope (#1063)
eece55d 
Add the metric user attribute portion of the earlier enrichment work.

Pass send_default_pii into metric scope application and attach user.id, user.name, and user.email from the scope when that option is enabled. Preserve explicitly set `user.*` metric attributes instead of overwriting them.

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Closes #1060
Closes [RUST-188](https://linear.app/getsentry/issue/RUST-188/add-trace-metric-user-attribute-enrichment-gated-by-send-default-pii)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-defaults-scoped branch from 2b6b592 to 092db6b Compare April 21, 2026 12:46
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/user-attributes-metrics branch from aa6f863 to eece55d Compare April 21, 2026 12:47
szokeasaurusrex added a commit that referenced this pull request Apr 21, 2026
@szokeasaurusrex @jjbayer
feat(metrics): Add metric user attributes from scope (#1063)
787d60a 
Add the metric user attribute portion of the earlier enrichment work.

Pass send_default_pii into metric scope application and attach user.id, user.name, and user.email from the scope when that option is enabled. Preserve explicitly set `user.*` metric attributes instead of overwriting them.

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Closes #1060
Closes [RUST-188](https://linear.app/getsentry/issue/RUST-188/add-trace-metric-user-attribute-enrichment-gated-by-send-default-pii)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-defaults-scoped branch from 092db6b to 9838831 Compare April 21, 2026 15:20
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/user-attributes-metrics branch from eece55d to 787d60a Compare April 21, 2026 15:20
cursor[bot]

This comment was marked as low quality.

Sign in to view

@szokeasaurusrex szokeasaurusrex mentioned this pull request Apr 22, 2026
Merged
szokeasaurusrex added a commit that referenced this pull request Apr 22, 2026
@szokeasaurusrex @jjbayer
feat(metrics): Add metric user attributes from scope (#1063)
807de4c 
Add the metric user attribute portion of the earlier enrichment work.

Pass send_default_pii into metric scope application and attach user.id, user.name, and user.email from the scope when that option is enabled. Preserve explicitly set `user.*` metric attributes instead of overwriting them.

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Closes #1060
Closes [RUST-188](https://linear.app/getsentry/issue/RUST-188/add-trace-metric-user-attribute-enrichment-gated-by-send-default-pii)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-defaults-scoped branch from 9838831 to 60371a2 Compare April 22, 2026 17:49
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/user-attributes-metrics branch from 787d60a to 807de4c Compare April 22, 2026 17:49
szokeasaurusrex added a commit that referenced this pull request Apr 23, 2026
@szokeasaurusrex @jjbayer
feat(metrics): Add metric user attributes from scope (#1063)
28bf132 
Add the metric user attribute portion of the earlier enrichment work.

Pass send_default_pii into metric scope application and attach user.id, user.name, and user.email from the scope when that option is enabled. Preserve explicitly set `user.*` metric attributes instead of overwriting them.

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Closes #1060
Closes [RUST-188](https://linear.app/getsentry/issue/RUST-188/add-trace-metric-user-attribute-enrichment-gated-by-send-default-pii)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-defaults-scoped branch from 60371a2 to 7f844e8 Compare April 23, 2026 20:54
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/user-attributes-metrics branch from 807de4c to 28bf132 Compare April 23, 2026 20:54
szokeasaurusrex added a commit that referenced this pull request Apr 23, 2026
@szokeasaurusrex @jjbayer
feat(metrics): Add metric user attributes from scope (#1063)
aab78c9 
Add the metric user attribute portion of the earlier enrichment work.

Pass send_default_pii into metric scope application and attach user.id, user.name, and user.email from the scope when that option is enabled. Preserve explicitly set `user.*` metric attributes instead of overwriting them.

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Closes #1060
Closes [RUST-188](https://linear.app/getsentry/issue/RUST-188/add-trace-metric-user-attribute-enrichment-gated-by-send-default-pii)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-defaults-scoped branch from 7f844e8 to 208b3ae Compare April 23, 2026 21:21
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/user-attributes-metrics branch from 28bf132 to aab78c9 Compare April 23, 2026 21:21
szokeasaurusrex added a commit that referenced this pull request Apr 23, 2026
@szokeasaurusrex @jjbayer
feat(metrics): Add metric user attributes from scope (#1063)
aeedb59 
Add the metric user attribute portion of the earlier enrichment work.

Pass send_default_pii into metric scope application and attach user.id, user.name, and user.email from the scope when that option is enabled. Preserve explicitly set `user.*` metric attributes instead of overwriting them.

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Closes #1060
Closes [RUST-188](https://linear.app/getsentry/issue/RUST-188/add-trace-metric-user-attribute-enrichment-gated-by-send-default-pii)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-defaults-scoped branch from 208b3ae to f30b17a Compare April 23, 2026 21:25
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/user-attributes-metrics branch from aab78c9 to aeedb59 Compare April 23, 2026 21:25
szokeasaurusrex added a commit that referenced this pull request Apr 24, 2026
@szokeasaurusrex @jjbayer
feat(metrics): Add metric user attributes from scope (#1063)
1d9898c 
Add the metric user attribute portion of the earlier enrichment work.

Pass send_default_pii into metric scope application and attach user.id, user.name, and user.email from the scope when that option is enabled. Preserve explicitly set `user.*` metric attributes instead of overwriting them.

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Closes #1060
Closes [RUST-188](https://linear.app/getsentry/issue/RUST-188/add-trace-metric-user-attribute-enrichment-gated-by-send-default-pii)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/user-attributes-metrics branch from aeedb59 to 1d9898c Compare April 24, 2026 12:39
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-defaults-scoped branch from f30b17a to 31ee7b5 Compare April 24, 2026 12:40
szokeasaurusrex added a commit that referenced this pull request Apr 28, 2026
@szokeasaurusrex @jjbayer
feat(metrics): Add metric user attributes from scope (#1063)
98f78df 
Add the metric user attribute portion of the earlier enrichment work.

Pass send_default_pii into metric scope application and attach user.id, user.name, and user.email from the scope when that option is enabled. Preserve explicitly set `user.*` metric attributes instead of overwriting them.

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Closes #1060
Closes [RUST-188](https://linear.app/getsentry/issue/RUST-188/add-trace-metric-user-attribute-enrichment-gated-by-send-default-pii)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-defaults-scoped branch from 31ee7b5 to 8e2dabe Compare April 28, 2026 09:22
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/user-attributes-metrics branch from 1d9898c to 98f78df Compare April 28, 2026 09:22
szokeasaurusrex added a commit that referenced this pull request Apr 28, 2026
@szokeasaurusrex @jjbayer
feat(metrics): Add metric user attributes from scope (#1063)
a628e6f 
Add the metric user attribute portion of the earlier enrichment work.

Pass send_default_pii into metric scope application and attach user.id, user.name, and user.email from the scope when that option is enabled. Preserve explicitly set `user.*` metric attributes instead of overwriting them.

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Closes #1060
Closes [RUST-188](https://linear.app/getsentry/issue/RUST-188/add-trace-metric-user-attribute-enrichment-gated-by-send-default-pii)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-defaults-scoped branch from 8e2dabe to e1f4dd0 Compare April 28, 2026 12:38
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/user-attributes-metrics branch from 98f78df to a628e6f Compare April 28, 2026 12:38
@szokeasaurusrex @jjbayer
feat(metrics): Add metric user attributes from scope (#1063)
3c4abb6 
Add the metric user attribute portion of the earlier enrichment work.

Pass send_default_pii into metric scope application and attach user.id, user.name, and user.email from the scope when that option is enabled. Preserve explicitly set `user.*` metric attributes instead of overwriting them.

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Closes #1060
Closes [RUST-188](https://linear.app/getsentry/issue/RUST-188/add-trace-metric-user-attribute-enrichment-gated-by-send-default-pii)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-defaults-scoped branch from e1f4dd0 to 0e46166 Compare April 28, 2026 13:27
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/user-attributes-metrics branch from a628e6f to 3c4abb6 Compare April 28, 2026 13:27
Base automatically changed from szokeasaurusrex/metrics-defaults-scoped to master April 28, 2026 13:49
@szokeasaurusrex szokeasaurusrex merged commit 3c4abb6 into master Apr 28, 2026
23 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/user-attributes-metrics branch April 28, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcian lcian lcian approved these changes

@cursor cursor[bot] cursor[bot] left review comments

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add trace metric user attribute enrichment gated by send_default_pii in sentry-core

2 participants

@szokeasaurusrex @lcian