Repository navigation
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
This adds an opt-in patch to sentry-resque for resque-scheduler's recurring schedules (
cronandevery, static and dynamic):Schedules in
exclude_scheduled_jobsare skipped; strings match the schedule name, regexps are matched against it.Each run sends in-progress and ok/error check-ins, with the schedule name as the slug and its schedule as the monitor config.
Resque::Job#perform, so they cover the job itself rather than the enqueue.TZ/Time.zone, then the system zone.sentry_monitor: false, so with feat(crons): Add rufus-scheduler cron monitoring #3110's:rufus_schedulerpatch also enabled they're skipped there instead of being reported twice or logging a warning.Stacked on #3141. The lockfile changes only add
resque-scheduler(already resolved throughresque-retry) as a direct dev dependency.