-
-
Notifications
You must be signed in to change notification settings - Fork 360
feat(ios): Default to consuming sentry-cocoa as an xcframework #6381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alwx
wants to merge
21
commits into
main
Choose a base branch
from
alwx/feature/spm-by-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c8143aa
feat(ios): Default to consuming sentry-cocoa via Swift Package Manager
alwx 611b091
Merge branch 'main' into alwx/feature/spm-by-default
alwx 347198e
docs(changelog): Link SPM entry to PR and flag breaking-change escapeโฆ
alwx a18cb61
Merge branch 'main' into alwx/feature/spm-by-default
alwx e06dcf2
fix(ios): Use Sentry-Dynamic SPM product to avoid archive signature cโฆ
alwx c1b534e
Merge branch 'main' into alwx/feature/spm-by-default
alwx 48c5743
fix(ios): Use SentrySPM source product to avoid archive signature colโฆ
alwx 9987701
Revert "fix(ios): Use SentrySPM source product to avoid archive signaโฆ
alwx eb8a766
feat(ios): Vendor sentry-cocoa as prebuilt xcframework instead of SPM
alwx 1ed61c6
fix(ios): Use Sentry (static) xcframework so CocoaPods resolves the mโฆ
alwx e92872e
fix(ios): Address reviewer feedback on xcframework install
alwx 99df7eb
fix(ios): Add explicit FRAMEWORK_SEARCH_PATHS for vendored Sentry.xcfโฆ
alwx 4a13dc4
fix(ios): Build pod_target_xcconfig locally, assign once
alwx fec31a0
fix(ios): Assign pod_target_xcconfig before install_modules_dependencies
alwx bcaf4ba
fix(ios): Enumerate Sentry.xcframework slice dirs for FRAMEWORK_SEARCโฆ
alwx 81d7a9c
fix(ios): SDK-conditional framework search paths per xcframework slice
alwx 1bbd6f7
Merge branch 'main' into alwx/feature/spm-by-default
alwx 69d9dbb
fix(ios): Use absolute xcframework path + Swift link stub
alwx f702c1b
fix(ios): Gate Swift link stub inclusion on RN >= 0.75
alwx 830db75
Merge branch 'main' into alwx/feature/spm-by-default
alwx 9171a88
fix: Address reviewer feedback on CHANGELOG placement and Swift stub
alwx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // This file exists to force Xcode to link the Swift runtime compatibility | ||
| // libraries (e.g. libswiftCompatibility56, libswiftCompatibilityConcurrency) | ||
| // into RNSentry. Those libs are required by our vendored `Sentry.xcframework` | ||
| // static Swift library and Xcode only auto-links them when the consuming | ||
| // target itself contains Swift code โ without this stub, linking a dynamic | ||
| // RNSentry framework fails with: | ||
| // Undefined symbols: "__swift_FORCE_LOAD_$_swiftCompatibility56" | ||
|
sentry[bot] marked this conversation as resolved.
|
||
|
|
||
| // A private, unused constant so the compiler emits a real object file. A | ||
| // pure-comment file compiles to nothing and would defeat the purpose of | ||
| // the stub. | ||
| private let _rnSentrySwiftLinkStub: Void = () | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.