Repository navigation
test(mcp): Remove unused select_mcp_transactions fixture - #8150
Merged
Merged
Conversation
Co-Authored-By: Ivana Kellyer <ivana.kellyer@sentry.io>
sentrivana
approved these changes
Oct 29, 2026
Contributor
Coverage Results 📊✅ 136856 passed | ⏭️ 7456 skipped | Total: 144312 | Pass Rate: 94.83% | Execution Time: 442m 19s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Coverage diff@@ Coverage Diff @@
## master #8150 +/-##
==========================================
+ Coverage 90.30% 90.33% +0.03%
==========================================
Files 203 203 —
Tracked lines 26873 26873 —
Branches 10044 10044 —
==========================================
+ Hits 24266 24275 +9
+ Misses 2607 2598 -9
+ Partials 1520 1518 -2Generated by Coverage Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
select_mcp_transactionsfixture fromtests/conftest.py. Nothing has used it since #5292.#5383 added it as a helper in the MCP tests, and #5384 turned it into a shared
conftest.pyfixture for the MCP and FastMCP Streamable HTTP tests. A few days later, #5292 ("Nest MCP spans under HTTP transactions") switched those tests toselect_transactions_with_mcp_spansand removed every use ofselect_mcp_transactions, but left the definition behind.Evidence
git grep select_mcp_transactionsmatches only the definition. No test requests it as an argument, and norequest.getfixturevalue(...)call uses that name.This only touches test code, so SDK behavior doesn't change.
Issues
n/a
via Ivana Kellyer.
--
View Junior Session [Sentry]