feat(openai): Gate response output collection on data collection options - #7035
Draft
ericapisani wants to merge 2 commits into
Draft
feat(openai): Gate response output collection on data collection options#7035ericapisani wants to merge 2 commits into
ericapisani wants to merge 2 commits into
Conversation
Gate OpenAI response text and tool calls collection on the new data_collection settings, giving precedence over the legacy send_default_pii flag for backwards compatibility. Applies to Chat Completions API, Responses API, and their streaming variants. Refs PY-2588
Contributor
Codecov Results 📊✅ 99165 passed | ❌ 1 failed | ⏭️ 6527 skipped | Total: 105693 | Pass Rate: 93.82% | Execution Time: 361m 37s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Tests
|
| File | Patch % | Lines |
|---|---|---|
| sentry_sdk/integrations/openai.py | 95.45% |
Coverage diff
@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.91% 89.93% +0.02%
==========================================
Files 193 193 —
Lines 24828 24865 +37
Branches 8930 8968 +38
==========================================
+ Hits 22322 22361 +39
- Misses 2506 2504 -2
- Partials 1416 1413 -3Generated by Codecov Action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate OpenAI response text and tool calls collection on the new data_collection settings, giving precedence over the legacy send_default_pii flag for backwards compatibility.
Applies to Chat Completions API, Responses API, and their streaming variants.
Refs PY-2588