Repository navigation
Conversation
Litarnus
added this pull request to stack #2262
October 17, 2026 15:50
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Litarnus
force-pushed
the
continuous-profiling-20-start-before-init
branch
from
October 17, 2026 15:59
b44483f to
f23eadd
Compare
Litarnus
force-pushed
the
continuous-profiling-20-start-before-init
branch
from
October 17, 2026 23:07
f23eadd to
3d61d82
Compare
Litarnus
removed this pull request from stack #2262
October 17, 2026 23:14
Litarnus
added this pull request to stack #2282
October 17, 2026 23:16
Litarnus
force-pushed
the
continuous-profiling-20-start-before-init
branch
from
October 18, 2026 10:45
3d61d82 to
8ee69f5
Compare
Litarnus
force-pushed
the
continuous-profiling-20-start-before-init
branch
from
October 18, 2026 14:53
8ee69f5 to
b751ab8
Compare
Litarnus
force-pushed
the
continuous-profiling-20-start-before-init
branch
from
October 18, 2026 19:19
b751ab8 to
1939d55
Compare
Litarnus
force-pushed
the
continuous-profiling-20-start-before-init
branch
from
October 18, 2026 19:47
1939d55 to
dbecf4e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dbecf4e. Configure here.
| $this->profiler->stop(); | ||
|
|
||
| $this->clearProfiler(); | ||
| } |
There was a problem hiding this comment.
Client bind skips forked profiler restart
Low Severity
onClientBound never calls restartInForkedProcess before keeping or tearing down a profiler. After pcntl_fork between a pre-init start() and client bind, a child can keep an inherited Excimer instance that does not sample, or emit warnings from stop() and teardown, because that timer does not exist in the child.
Reviewed by Cursor Bugbot for commit dbecf4e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to start manual profiling before the SDK was initialised (and thus missing sampling decisions). Once a client is bound, it will either keep the samples or discard them, depending on the SDK options.