Skip to content

feat(profiling): stop profiler on context end - #2274

Open
Litarnus wants to merge 1 commit into
continuous-profiling-13-flush-profilerfrom
continuous-profiling-14-release-roots-on-end-context
Open

Litarnus wants to merge 1 commit into
continuous-profiling-13-flush-profilerfrom
continuous-profiling-14-release-roots-on-end-context

Conversation

@Litarnus

@Litarnus Litarnus commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

The profiler will now also be stopped once a RuntimeContext ends to prevent any leaks. In runtimes such as FrankenPHP, a non properly finished transaction might keep a span alive and would never stop the profiler.

This only applies to trace profiling because only that will populate the root spans, manual tracing is unaffected

@Litarnus
Litarnus added this pull request to stack #2262 October 16, 2026 17:35
@Litarnus
Litarnus force-pushed the continuous-profiling-14-release-roots-on-end-context branch from d70fdcc to fd646f3 Compare October 17, 2026 21:30

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fd646f3. Configure here.

Comment thread src/State/RuntimeContextManager.php
@Litarnus
Litarnus removed this pull request from stack #2262 October 17, 2026 23:14
@Litarnus
Litarnus added this pull request to stack #2282 October 17, 2026 23:16
@Litarnus
Litarnus force-pushed the continuous-profiling-14-release-roots-on-end-context branch from fd646f3 to 5df0b1b Compare October 18, 2026 10:45
@Litarnus
Litarnus force-pushed the continuous-profiling-14-release-roots-on-end-context branch from 5df0b1b to c0a208e Compare October 18, 2026 19:19
@Litarnus
Litarnus force-pushed the continuous-profiling-14-release-roots-on-end-context branch from c0a208e to 5dd77b5 Compare October 18, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant