Skip to content

ref: remove AgentClient from agent repo#37

Open
Litarnus wants to merge 2 commits intomainfrom
cleanup-agent-client
Open

ref: remove AgentClient from agent repo#37
Litarnus wants to merge 2 commits intomainfrom
cleanup-agent-client

Conversation

@Litarnus
Copy link
Copy Markdown
Contributor

Removes the AgentClient from this repo because it was moved to the PHP SDK.

The structure remained unchanged for now

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 810dee9. Configure here.

Comment thread agent/composer.json
"react/http": "^1.11",
"react/socket": "^1.16",
"sentry/sentry": "^4.19.1"
"sentry/sentry": "dev-master as 4.26.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale lock file breaks agent build process

High Severity

The sentry/sentry requirement changed from ^4.19.1 to dev-master as 4.26.0, but agent/composer.lock was not regenerated and still locks sentry/sentry at 4.19.1. The build script (scripts/build.sh) runs composer install, which reads from the lock file and will fail because the locked version no longer satisfies the new constraint. This breaks the PHAR build process.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 810dee9. Configure here.

Comment thread composer.json
"require": {
"php": "^7.2|^8",
"ext-json": "*",
"sentry/sentry": "^4.19.1"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example broken by removed sentry/sentry dependency

Medium Severity

The sentry/sentry package was removed entirely from the root composer.json dependencies, but examples/send.php was updated (not deleted) and still relies on classes from that package — AgentClientBuilder, Sentry\init(), and Sentry\captureMessage(). The example loads the root autoloader via require_once __DIR__ . '/../vendor/autoload.php', indicating it's meant to be runnable from this repo. Without sentry/sentry at least in require-dev, the example will fail with class-not-found errors after composer install.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 810dee9. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant