ref(internal): add sentry_telemetry module - #1943
Merged
Merged
Conversation
jpnurmi
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1943 +/- ##
==========================================
+ Coverage 75.94% 75.97% +0.02%
==========================================
Files 93 94 +1
Lines 22183 22161 -22
Branches 3951 3936 -15
==========================================
- Hits 16847 16836 -11
+ Misses 4451 4440 -11
Partials 885 885 🚀 New features to boost your workflow:
|
jpnurmi
force-pushed
the
jpnurmi/ref/sentry-telemetry
branch
from
August 3, 2026 16:28
7dc8f85 to
0583e02
Compare
jpnurmi
marked this pull request as ready for review
August 3, 2026 16:28
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0583e02. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
jpnurmi
force-pushed
the
jpnurmi/ref/sentry-telemetry
branch
from
August 4, 2026 08:09
ff2f6a7 to
8bfdf9d
Compare
JoshuaMoelans
approved these changes
Aug 4, 2026
Add an internal telemetry lifecycle layer for logs and metrics startup, shutdown, force flush, and crash-safe flush. Keep the existing logs and metrics behavior behind the shared coordination API.
jpnurmi
force-pushed
the
jpnurmi/ref/sentry-telemetry
branch
from
August 4, 2026 12:36
8bfdf9d to
cdc41e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an internal
sentry_telemetrymodule with a shared coordination API for starting up, flushing, and shutting down logs and metrics. Later on, the telemetry module will be used to manage a shared thread pool. Also, lifting up the "shutting down logs/metrics system" etc. debug logs to the shared module helps to reduce those repetitive logs.#skip-changelog (internal)