feat: expose attachment types#1700
Conversation
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e4abe3d. Configure here.
|
Should we deprecate |
Hmm, yeah, we probably could. Besides sentry-native and its forks and vendored copies, I can only find public references in sentry-godot and sentry-docs. |
|
Will get back to this after #1705, which removes the configure-time attachment limitation on macOS and allows deprecating |
Expose attachment type setters together with well-known type constants so downstream SDKs can mark attachments such as view hierarchy payloads as "event.view_hierarchy". Co-Authored-By: OpenAI Codex <noreply@openai.com>
jpnurmi
force-pushed
the
jpnurmi/feat/attachment-type
branch
from
2755f82 to
ebbe27a
Compare
Keep sentry__attachments_add focused on inserting already-configured attachments. Configure type and content type in the path helper, and preserve those fields when cloning attachments. Co-Authored-By: OpenAI Codex <noreply@openai.com>
limbonaut
left a comment
limbonaut
left a comment
There was a problem hiding this comment.
I'd also add a note to doc comments about content_type side-effect. Looks good otherwise.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
3 participants
Allow downstream SDKs to attach files and bytes with standard Sentry attachment types, such as
event.view_hierarchyorevent.minidump.This is more flexible than
sentry_options_add_view_hierarchy()that a) requires a file on the disk, which must be frequently updated in case of view hierarchy, and b) pushes session management to the downstream SDKs, because they don't have access to the .run directory for multi-process support and automatic cleanup.