Repository navigation
fix(node): Read syncBuiltinESMExports off the module namespace so Deno can load @sentry/node - #26155
Merged
Merged
Conversation
…o can load @sentry/node Deno before 2.8.2 has syncBuiltinESMExports only on the default export of node:module, so the named import from #26086 failed to link and every ESM import of @sentry/node threw.
Contributor
size-limit report 📦Compared: 4a01849 (PR test merge using develop at c7d2764) Against: c7d2764 (develop) · base run #65121 ✅ Baseline matches: this diff contains only this PR's changes.
|
logaretm
marked this pull request as ready for review
November 5, 2026 19:12
logaretm
requested review from
andreiborza and
isaacs
and removed request for
a team
November 5, 2026 19:12
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 62b922d. Configure here.
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 5 not successful, 40 successful. See the run.
Successful checks
|
isaacs
approved these changes
Nov 5, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
Yes, it's edgy, but not crashing is an improvement 👍
43081j
pushed a commit
to 43081j/sentry-javascript
that referenced
this pull request
Nov 9, 2026
…o can load @sentry/node (getsentry#26155) Importing `@sentry/node` under Deno before 2.8.2 would fail due to getsentry#26086 named-imported `syncBuiltinESMExports`, which those versions only expose on the default export of `node:module`, fixed by reading it off the module namespace instead. I found this while running an exports check on different runtimes, it is very low impact and severity as I don't expect deno users to run the Node SDK stuff there, but this didn't break before either. Feel free to close if too edgy.
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing
@sentry/nodeunder Deno before 2.8.2 would fail due to #26086 named-importedsyncBuiltinESMExports, which those versions only expose on the default export ofnode:module, fixed by reading it off the module namespace instead.I found this while running an exports check on different runtimes, it is very low impact and severity as I don't expect deno users to run the Node SDK stuff there, but this didn't break before either. Feel free to close if too edgy.