Repository navigation
test(browser): Stabilize long animation frame tests - #25974
Open
nicohrubec wants to merge 1 commit into
Open
nicohrubec wants to merge 1 commit into
nicohrubec wants to merge 1 commit into
Conversation
Co-Authored-By: OpenAI Codex <codex@openai.com>
Contributor
size-limit report 📦Compared: 10fd1e8 (PR test merge using develop at f74a45d) Against: f74a45d (develop) · base run #64531 ✅ Baseline matches: this diff contains only this PR's changes.
|
nicohrubec
marked this pull request as ready for review
October 31, 2026 09:23
nicohrubec
requested review from
logaretm and
msonnb
and removed request for
a team
October 31, 2026 09:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Mouse-down and click can share a long animation frame, which the SDK attributes to its first script instead of the click handler these tests expect. Waiting for a frame boundary before mouse-up isolates the click.