Repository navigation
fix(nuxt): Keep storage instrumentation plugin synchronous - #25949
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Nitro v3 RC awaits async plugins and defers every later plugin until the promise settles. Our async (but never awaiting) storage plugin turned all subsequent plugins async, so a plugin throwing at startup became an unhandled rejection instead of crashing the server. Also opt the nuxt-5 e2e app into the `kv` cache driver: Nitro v3 RC's default `memory` cache driver no longer goes through KV storage, so cached functions/handlers are not visible to the storage instrumentation. Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
Contributor
size-limit report 📦Compared: 470c120 (PR test merge using develop at 7aca628) Against: 7aca628 (develop) · base run #64423 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 4 successful. See the run. Successful checks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The optional
nuxt-5E2E job broke whennitro@latestmoved from3.0.260903-betato3.0.261029-rc. The same develop SHA passed before that release and failed after it. Two separate Nitro changes caused it:asyncbut never awaited anything, so it pushed every plugin after it (including user plugins) into the async path. A plugin that throws at startup then turns into an unhandled rejection. OuronUnhandledRejectionhandler keeps the process running, so instead of exiting with code 1 the server keeps listening behind a rejectedreadygate. Making the plugin synchronous restores the old behavior. Nitro v2 never awaited plugins, so nothing changes there.defineCachedFunction/defineCachedHandlerare now built onocache, and the defaultmemorycache driver skips KV storage completely. The storage instrumentation can't see those calls anymore. The test app now setscache: { driver: 'kv' }, which is also what Nitro picks by default when acacheKV mount is configured, so cache instrumentation stays tested.Unsure about: With Nitro v3 RC's default config, users no longer get
cache.*spans for cached functions or handlers. Supporting that would need new instrumentation around ocache's storage, since there is no tracing channel for it. Cache keys also changed shape (nitrofunctions.<hash>:...instead ofnitro:functions:...), so the expired-entry check inisCacheHitno longer runs, and it falls back to checking whether a value is present. Should that be handled here, or tracked as a follow-up?via Francesco Gringl-Novy.
--
View Session [Sentry]