Repository navigation
fix(db): Allow connection spans without a parent - #25941
Draft
nicohrubec wants to merge 1 commit into
Draft
nicohrubec wants to merge 1 commit into
nicohrubec wants to merge 1 commit into
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
Contributor
size-limit report 📦Compared: f06120d (PR test merge using develop at b0560b7) Against: b0560b7 (develop) · base run #64377 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 not successful, 53 successful. See the run.
Successful checks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Connection and pool acquisition latency is useful during startup and reconnects, when no application span may be active. Allow these spans to be roots consistently across ioredis, MySQL2, and PostgreSQL, matching the connection paths that already allow this.
How to review: Query parent requirements stay unchanged. Existing tests now cover parentless connects and accept additional connection segments while retaining their query assertions.
Related to #25879.