Repository navigation
test(node-integration-tests): Install single-version suite dependencies as package dependencies - #25936
Merged
Conversation
…es as package dependencies The typesafe, Bedrock and MCP SDK v1 suites each test one version that does not conflict with anything at the package root, so they don't need a per-call `npm install` in a tmp dir. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: 0f4ec50 (PR test merge using develop at 365e761) Against: 365e761 (develop) · base run #64341 ✅ Baseline matches: this diff contains only this PR's changes.
|
1.30.0 is affected by several high-severity advisories, which fails dependency review now that it is a package dependency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 not successful, 55 successful. See the run.
Successful checks
|
mydea
marked this pull request as ready for review
October 30, 2026 10:53
mydea
requested review from
andreiborza,
chargome,
isaacs,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
October 30, 2026 10:53
nicohrubec
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The typesafe, Bedrock and MCP SDK v1 suites each test a single version that doesn't conflict with anything at the package root. For them, the unlocked per-call
npm installinto a tmp dir (network on every run, unpinned ranges, retries) buys nothing. Installing them once through pnpm makes them locked and faster. It's the same change as #25933 for Flue and pi-durable.For mcp v1, we do not need additional dependencies either, because the package names are actually different for v1 and v2 so we can just install them side-by-side.
How to review: Hide whitespace. Dropping the options argument re-indents the test bodies, and the assertions are unchanged.
Unsure about:
pnpm dedupe(enforced in CI) moves the shared@aws-sdkinternals forward a few patches (@aws-sdk/core3.978.1 → 3.978.7,@smithy/core3.35.2 → 3.37.0), because the Bedrock client needs newer ones.@google/genai's optional@modelcontextprotocol/sdkpeer now resolves to 1.30.0 instead of 1.32.2.tediousstays per-suite: the suite tests both the root v19 and v20, so it is a multi-version suite.🤖 Generated with Claude Code