Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
@lazerg please stop making contributions without asking before! Familiarize yourself with our contribution guidelines. As you've seen we had to close most of your previous PRs. We will have to ban you if this continues. |
Contributor
Author
|
Understood. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: On SvelteKit 3,
HandleandResolveOptionslive in@sveltejs/kit/hooksand are no longer exported from@sveltejs/kit, so our declarations import nothing andsentryHandle()/initCloudflareSentryHandle()come out typed asany. Neither import path works on both majors, so I deriveHandlefromsequence, which@sveltejs/kit/hooksexports with the same signature on Kit 2 and 3.How to review:
server-common/handle.tshas the derived types; the other two files only switch their import. I checked the built.d.tsagainst Kit 3.1.1 and 2.70.3 in a scratch project: on Kit 3 the return types wereanybefore and areHandlenow, Kit 2 is unchanged. No unit test, since the repo builds against Kit 2 and it only shows up on Kit 3.Closes #25924