Repository navigation
test(e2e): Rename nuxt-5 middleware files to avoid Nitro's dotted suffixes - #25923
Merged
Merged
Conversation
…fixes Nitro 3.0.261029-rc reads a second dot in a scanned file name as a reserved suffix, so `01.first.ts` failed the build and kept the middleware from loading in dev.
Member
Author
|
bugbot review |
Contributor
size-limit report 📦Compared: 363bb42 (PR test merge using develop at 9310b4d) Against: 9310b4d (develop) · base run #64312 ✅ Baseline matches: this diff contains only this PR's changes.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9ef8091. Configure here.
logaretm
marked this pull request as ready for review
October 30, 2026 03:30
logaretm
requested review from
Lms24,
andreiborza,
chargome,
isaacs,
msonnb and
nicohrubec
and removed request for
a team
October 30, 2026 03:30
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful. See the run.
|
Lms24
approved these changes
Oct 30, 2026
nicohrubec
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nitro
3.0.261029-rctreats the second dot in01.first.tsas a reserved suffix (nitrojs/nitro#4845), which broke the nuxt-5 build and kept the middleware from loading in dev.I just renamed the middlewares to
01-first.tsand so on to workaround it.