Repository navigation
fix(v10/core): Call native toString without page-replaceable lookups in FunctionToString - #25922
Merged
Merged
Conversation
…in FunctionToString Backport of: #25921
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e2ecfd9. Configure here.
logaretm
marked this pull request as ready for review
October 30, 2026 03:19
mydea
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25921
FunctionToStringcould overflow the stack, it happens when a page hooksFunction.prototype.applyor whentoStringgets a huge argument list, this can be fixed by capturing a binding to the native call once and passing no arguments.Why does a huge argument list trigger this? V8 only fits so many args on the stack. Our wrapper held two copies (the incoming call and our call to native
toString), so a huge list overflows where native's single copy fits. This is mentioned on MDN.I added tests for an apply hook that calls toString and a 100k argument call, both overflow before the fix.
Related to #22515, which removed the same kind of re-entry through
Reflect.apply. This is a guess at best at an issue that was reported, no guarantee it fixes it because it seems far fetched that this is what happened.