Repository navigation
feat(cloudflare): propagate tracing context through Queue messages #25306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arthurfiorette
wants to merge
10
commits into
getsentry:develop
Choose a base branch
from
arthurfiorette:arthurfiorette/queue-links
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0b05f24
code
arthurfiorette 0bd582c
fix review comments
arthurfiorette fe0b730
fix reviews
arthurfiorette 14ec356
Merge branch 'develop' into arthurfiorette/queue-links
arthurfiorette c905669
Merge upstream/develop and address review comments
arthurfiorette 86f1224
chore: Add CHANGELOG entry for queue trace propagation
arthurfiorette c783df9
Merge remote-tracking branch 'upstream/develop' into arthurfiorette/q…
arthurfiorette 3468c05
Merge remote-tracking branch 'upstream/develop' into arthurfiorette/q…
arthurfiorette 27dd16c
review comment
arthurfiorette ae7138a
remove hardcode comments
arthurfiorette File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,14 @@ | ||
| import { matchesTracePropagationTargets } from '@sentry/core'; | ||
| import { matchesTracePropagationTargets, type TracePropagationTargets } from '@sentry/core'; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Super low priority. Technically this file is doing more now than just |
||
| import type { CloudflareOptions } from '../client'; | ||
|
|
||
| const PROPAGATE_TO_NONE = () => false; | ||
|
|
||
| /** | ||
| * Builds the per-binding predicate that decides whether a binding takes part in RPC trace | ||
| * propagation. | ||
| * | ||
| * Callers only. Receivers continue an incoming trace whenever one arrives, so they have nothing to | ||
| * match against. | ||
| * Builds the per-binding predicate that decides whether a binding takes part in trace propagation. | ||
| */ | ||
| export function createRpcPropagationResolver(options: CloudflareOptions | undefined): (bindingName: string) => boolean { | ||
| const bindings = options?.rpcTracePropagationBindings; | ||
|
|
||
| export function createBindingPropagationResolver( | ||
| bindings: TracePropagationTargets | undefined, | ||
| ): (bindingName: string) => boolean { | ||
| if (!bindings?.length) { | ||
| return PROPAGATE_TO_NONE; | ||
| } | ||
|
|
@@ -21,3 +17,14 @@ export function createRpcPropagationResolver(options: CloudflareOptions | undefi | |
| // propagation for a binding named `MY_DB`. Regular expressions still give pattern matching. | ||
| return (bindingName: string) => matchesTracePropagationTargets(bindingName, bindings, true); | ||
| } | ||
|
|
||
| /** | ||
| * Builds the per-binding predicate that decides whether a binding takes part in RPC trace | ||
| * propagation. | ||
| * | ||
| * Callers only. Receivers continue an incoming trace whenever one arrives, so they have nothing to | ||
| * match against. | ||
| */ | ||
| export function createRpcPropagationResolver(options: CloudflareOptions | undefined): (bindingName: string) => boolean { | ||
| return createBindingPropagationResolver(options?.rpcTracePropagationBindings); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to myself. We might need to extend this in our Vite plugin to automatically add these in case they're in the same deployment