chore(ci): Do not build AWS lambda layer in build step#20357
chore(ci): Do not build AWS lambda layer in build step#20357
Conversation
…install Replace `file:` directory references with `npm pack` tarballs when installing @sentry/* packages into the Lambda layer's node_modules. Previously, `yarn install` used `file:` references to workspace packages with a fresh cache folder (to avoid stale cache issues), taking ~52s. With tarballs, yarn can use its global cache and the install completes in ~8s. Only transitive dependencies of @sentry/aws-serverless are packed (~5 packages), keeping the packing step fast. Total layer build time: ~97s → ~15s. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Instead, only build this before uploading artifacts, as we do not really need this before.
…l-based install" This reverts commit 7203205.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Generally looks good to me, we just need to be careful about build:extension as it is important for the npm package too now. As long as build:layer is called before publishing the npm package this works. I don't know off the top of my head if that's the case tho.
Edit: ah yea what cursor is saying above. Tbh I'd just keep the build:extension step but exclude build:layer from build.
size-limit report 📦
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f1e1d97. Configure here.
| job_build_layer: | ||
| name: Build Lambda layer | ||
| needs: [job_get_metadata, job_build] | ||
| if: needs.job_build.outputs.changed_aws_serverless == 'true' || github.event_name != 'pull_request' |
There was a problem hiding this comment.
E2E test fails when layer artifact is missing
Medium Severity
The job_build_layer condition checks only if @sentry/aws-serverless is in the Nx affected list, but the E2E matrix includes aws-serverless whenever any Sentry dependency of the test app is affected. The aws-serverless E2E app also depends on @sentry-internal/test-utils. If a PR changes only test-utils, job_build_layer is skipped (no build-layer-output artifact uploaded), yet the aws-serverless E2E test is still included in the matrix and attempts to download the missing artifact, causing a CI failure.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit f1e1d97. Configure here.
2 participants
To slightly improve build times, I figured we can actually skip building the AWS lambda layer all the time in our
buildstep, as, AFAIK, we don't really need this for any tests etc. Instead, we only need this when uploading artifacts for publishing, so I moved this into that step. To ensure we do not accidentally regress this, I also added a standalone job that can run in parallel that verifies that building this still works.