feat(core): Emit no_parent_span client outcomes for discarded spans requiring a parent#20350
Open
feat(core): Emit no_parent_span client outcomes for discarded spans requiring a parent#20350
no_parent_span client outcomes for discarded spans requiring a parent#20350Conversation
… requiring a parent
Contributor
size-limit report 📦
|
s1gr1d
reviewed
Apr 17, 2026
Comment on lines
51
to
+56
| const shouldSkipSpan = options.onlyIfParent && !trace.getSpan(activeCtx); | ||
| const ctx = shouldSkipSpan ? suppressTracing(activeCtx) : activeCtx; | ||
|
|
||
| if (shouldSkipSpan) { | ||
| getClient()?.recordDroppedEvent('no_parent_span', 'span'); | ||
| } |
Member
There was a problem hiding this comment.
Maybe this could be made a bit more robust. Right now it's checking shouldSkipSpan but the value of the variable could depend on something else than onlyIfParent in the future. Then this would be wrong.
The test also only check for dropped events and not necessarily that this resulted because of a missing parent span.
Member
There was a problem hiding this comment.
Yeah I guess we could inline the variable or name it a bit more precise, unless you had something else in mind?
nicohrubec
reviewed
Apr 17, 2026
| import { afterAll, describe, expect } from 'vitest'; | ||
| import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner'; | ||
|
|
||
| describe('no_parent_span client report (streaming)', () => { |
Member
There was a problem hiding this comment.
Suggested change
| describe('no_parent_span client report (streaming)', () => { | |
| describe('no_parent_span client report', () => { |
| | 'ignored' | ||
| | 'invalid'; | ||
| | 'invalid' | ||
| | 'no_parent_span'; |
Member
There was a problem hiding this comment.
do we need a change in relay for this?
Comment on lines
51
to
+56
| const shouldSkipSpan = options.onlyIfParent && !trace.getSpan(activeCtx); | ||
| const ctx = shouldSkipSpan ? suppressTracing(activeCtx) : activeCtx; | ||
|
|
||
| if (shouldSkipSpan) { | ||
| getClient()?.recordDroppedEvent('no_parent_span', 'span'); | ||
| } |
Member
There was a problem hiding this comment.
Yeah I guess we could inline the variable or name it a bit more precise, unless you had something else in mind?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds reporting a client discard outcome for spans we skip because they require a parent span to be active. This happens when
onlyIfParent: trueis set when starting spans, or in custom logic forhttp.clientspans. With this PR, we should now get a much clearer picture of how many spans users are missing out on.In span streaming, we'll always emit them (see #17932) spans.
closes https://linear.app/getsentry/issue/SDK-1123/add-client-report-outcome-for-dropped-spans-because-of-missing-parent