Skip to content

ref(android): Support updates to nav state across multiple SentryNavEffect instances #6229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
0xadam-brown wants to merge 1 commit into
base: main
Choose a base branch
from
+2,397 −25
Draft

ref(android): Support updates to nav state across multiple SentryNavEffect instances #6229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
animalsniffer = "2.0.1"
apollo = "2.5.9"
androidxLifecycle = "2.2.0"
androidxLifecycleCompose = "2.8.7" # Nav3 needs LocalLifecycleOwner (2.8+); keep Android core's runtime baseline separate.
androidxNavigation = "2.9.8"
androidxNavigation3 = "1.1.5"
androidxTestCore = "1.7.0"
Expand Down Expand Up @@ -106,6 +107,7 @@ androidx-core = { module = "androidx.core:core", version = "1.3.2" }
androidx-core-ktx = { module = "androidx.core:core-ktx", version = "1.7.0" }
androidx-fragment-ktx = { module = "androidx.fragment:fragment-ktx", version = "1.3.5" }
androidx-lifecycle-common-java8 = { module = "androidx.lifecycle:lifecycle-common-java8", version.ref = "androidxLifecycle" }
androidx-lifecycle-runtime-compose = { module = "androidx.lifecycle:lifecycle-runtime-compose", version.ref = "androidxLifecycleCompose" }
androidx-lifecycle-process = { module = "androidx.lifecycle:lifecycle-process", version.ref = "androidxLifecycle" }
androidx-navigation-runtime = { module = "androidx.navigation:navigation-runtime", version.ref = "androidxNavigation" }
androidx-navigation-compose = { module = "androidx.navigation:navigation-compose", version.ref = "androidxNavigation" }
Expand Down
1 change: 1 addition & 0 deletions sentry-android-navigation3/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ dependencies {
implementation(projects.sentry)

compileOnly(libs.androidx.compose.runtime)
compileOnly(libs.androidx.lifecycle.runtime.compose)

testImplementation(libs.androidx.compose.ui.test.junit4)
testImplementation(libs.androidx.test.core)
Expand Down
3 changes: 2 additions & 1 deletion ...ry-android-navigation3/src/main/kotlin/io/sentry/compose/navigation3/BackStackObserver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import io.sentry.protocol.TransactionNameSource
import io.sentry.util.IntegrationUtils.addIntegrationToSdkVersion
import java.lang.ref.WeakReference

internal const val NAVIGATION_CONTEXT_KEY: String = "Navigation"

private const val NAVIGATION_OP: String = "navigation"

/**
Expand Down Expand Up @@ -374,7 +376,6 @@ private class NavContext(private val scopes: IScopes, private val options: Sentr

private companion object {
private const val BACKSTACK_KEY = "Back Stack"
private const val NAVIGATION_CONTEXT_KEY = "Navigation"
}

fun update(scope: IScope, backStackEntries: List<NormalizedSentryBackStackEntry>) {
Expand Down
Loading
Loading