Repository navigation
ref(android): Extract shared nav sample app infrastructure into common package - #6220
Merged
Merged
Conversation
0xadam-brown
requested review from
adinauer,
markushi,
romtsn and
runningcode
as code owners
October 5, 2026 07:01
📲 Install BuildsAndroid
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
0xadam-brown
force-pushed
the
ref/extract-shared-sample-app-infra
branch
from
October 5, 2026 08:14
ebef890 to
934023b
Compare
0xadam-brown
force-pushed
the
ref/sentry-nav-effect-performance
branch
from
October 5, 2026 08:21
f5563cb to
d42fc93
Compare
0xadam-brown
force-pushed
the
ref/extract-shared-sample-app-infra
branch
from
October 5, 2026 08:33
934023b to
453271d
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 453271d. Configure here.
…on package Move shared navigation sample infrastructure into the io.sentry.samples.android.navigation.common package and isolate the existing Nav2 implementation under its own package. Keep Nav2 performance controls focused while wiring route-work support and launcher resources for the sample foundation. Lays the groundwork for the Nav3 sample app. Co-Authored-By: Codex <noreply@openai.com>
Close Retrofit response bodies for both synchronous and asynchronous route-work requests so repeated navigation cannot leak OkHttp connections. Co-Authored-By: Codex <noreply@openai.com>
0xadam-brown
force-pushed
the
ref/extract-shared-sample-app-infra
branch
from
October 6, 2026 03:53
bef6b0f to
5d20ce5
Compare
Member
Author
|
Rebased on an updated target; otherwise unchanged. |
romtsn
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Move shared nav sample app infrastructure into the
io.sentry.samples.android.navigation.commonpackage and isolate the existing Nav2 implementation under its own package.💡 Motivation and Context
Lays the groundwork for the Nav3 sample app, which will make use of the
.commonclasses.💚 How did you test it?
Manually via sample app installation / interaction.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps