fix(core): Handle callback errors by adinauer · Pull Request #6140 · getsentry/sentry-java

adinauer · 2026-09-22T04:33:18Z

PR Stack (Callback Errors)

📜 Description

Collects the callback error handling PR stack. The collection branch intentionally contains only an empty commit; the implementation lands through the stacked PRs below it.

💡 Motivation and Context

Filtering callback failures must not allow potentially partially processed telemetry to continue through the pipeline. This stack distinguishes callback failures in client reports and consistently drops affected telemetry or breadcrumbs.

resolves: Align callback error handling with other SDKs #6081

💚 How did you test it?

The cumulative stack passes focused sentry tests for SentryClientTest, ScopeTest, ScopesTest, and ClientReportTest, plus :sentry:apiCheck.

📝 Checklist

I added GH Issue ID & Linear ID
I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.
Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Merge the stack PRs bottom to top using merge commits, then squash-merge this collection PR into main.

sentry · 2026-09-22T04:34:59Z

📲 Install Builds

Android

🔗 App Name	App ID	Version	Configuration
SDK Size	io.sentry.tests.size	8.59.0 (1)	release

⚙️ sentry-android Build Distribution Settings

Add the callback_error discard reason and use it when a beforeSend callback throws. Preserve before_send for callbacks that intentionally return null and retain item, span, and byte accounting. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Stop processing and drop telemetry when an event processor throws. Record callback_error outcomes for every supported category instead of sending potentially partially processed data. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Drop breadcrumbs when beforeBreadcrumb throws instead of storing the breadcrumb with exception details. Keep observer state unchanged and release the callback reentrancy guard for later additions. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Add an internal marker to SDK event processors across core and integrations. Keep customer processors and the backfilling marker independent so later callback handling can distinguish ownership regardless of registration path. Leave exception handling unchanged in this preparatory change. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Make the preceding marker PR available to the processor failure policy. Preserve the existing stack commits and leave failure behavior unchanged. Co-Authored-By: Claude <noreply@anthropic.com>

Carry the inserted SDK processor marker forward through the adjacent stack branch without rewriting existing history or changing breadcrumb behavior. Co-Authored-By: Claude <noreply@anthropic.com>

Use the internal processor marker to continue processing after SDK-owned processor failures without recording callback_error losses. Keep customer processor failures fail-closed across events, transactions, replays, feedback, logs, and metrics. Cover scope and options registration, continued callbacks and delivery, logging without discard notifications, intentional drops, and span loss accounting. Clarify the customer-only failure policy in the changelog. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Merge #6142 forward into #6143 so SDK-owned processor failures preserve\ntelemetry throughout the stack. Keep the breadcrumb-only diff unchanged\nand retain both changelog entries without rewriting existing history.

Inherit the parent sampling decision when tracesSampler throws. Without a parent decision, leave the trace unsampled instead of applying the static tracesSampleRate, which can override the failed sampling policy. Keep normal null-result fallback, profiling callbacks, and catch types unchanged. Cover parent inheritance, backfilling, and static-rate bypass. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Link the tracesSampler failure fallback entry to #6163 in the callback error handling stack.

Disable profiling when profilesSampler throws instead of applying the static profilesSampleRate or inheriting a parent profiling decision. Preserve trace sampling metadata and normal null-result fallback. Cover static-rate bypass, parent inheritance, and failures in both samplers without changing existing catch types. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Link the profilesSampler failure handling entry to #6164 in the callback error handling stack.

Skip replay capture when beforeErrorSampling throws instead of capturing replay after a failed user filter. Continue sending the error event and retain existing exception logging and catch types. Cover handled errors, crashes, and successful replay capture after a previous callback failure. Verify error delivery and failure logging. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Link the beforeErrorSampling failure entry to PR #6165. Co-Authored-By: Claude <noreply@anthropic.com>

Record callback_error/profile when beforeSendTransaction or a customer transaction processor throws and an attached profile is dropped. Notify OnDiscardCallback through the same client-report accounting path. Cover scope and options processors, absent profiles, and SDK processor failures that retain profiles. Leave catch types, intentional drops, and profile-file cleanup unchanged. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Link the transaction profile loss accounting entry to PR #6166. Co-Authored-By: Claude <noreply@anthropic.com>

Skip Android screenshot and view hierarchy capture when their callbacks throw, while retaining the error event. Drop spans on beforeSpan failures in OkHttp, OpenFeign, GraphQL, Ktor, and Apollo without disrupting requests or replacing the original request error. Preserve normal callback results and existing catch types. Finish failed spans and retain request cleanup and breadcrumbs. Add regression coverage for callback failures, partial mutations, original request errors, asynchronous GraphQL results, and subsequent Android captures. Correct callback wiring in the Ktor and screenshot test fixtures. Verify 18 regression cases fail before the fix and pass afterward; all 454 tests in the affected suites pass, along with formatting and API checks. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Link the Android capture and integration beforeSpan callback fixes to Callback Errors 9 (#6167). Co-Authored-By: Claude <noreply@anthropic.com>

Replace parent-decision fallback after tracesSampler errors with an unsampled decision and callback_error reports for the transaction and root span. Preserve deliberate null-result fallback and existing catches. Report callback errors directly in the sampler and retain existing sample_rate and backpressure accounting, accepting duplicate loss reports instead of adding discard-reason propagation. Cover core and OpenTelemetry paths with regression tests and update the changelog. Refs #6163 Co-Authored-By: Claude <noreply@anthropic.com>

Merge the updated tracesSampler failure behavior from #6163 into #6164. Preserve profile-sampler isolation and update the combined-failure test to expect tracing and profiling to be disabled, even with a sampled parent. Refs #6163 Refs #6164 Co-Authored-By: Claude <noreply@anthropic.com>

Merge #6164 forward into #6165 without rewriting stack history. Retain replay sampling changes and the updated trace-sampler changelog. Refs #6165 Co-Authored-By: Claude <noreply@anthropic.com>

Merge #6165 forward into #6166 without rewriting stack history. Preserve attached-profile loss accounting alongside the sampler fixes. Refs #6166 Co-Authored-By: Claude <noreply@anthropic.com>

Merge #6166 forward into #6167 without rewriting stack history. Preserve integration callback guards alongside the updated sampler behavior. Validate the combined core and OpenTelemetry suites, formatting, and API checks. Refs #6167 Co-Authored-By: Claude <noreply@anthropic.com>

Record callback_error/span when a throwing beforeSpan callback drops a sampled span in OkHttp, OpenFeign, GraphQL, Ktor, and Apollo. Use the pre-callback sampling decision so partial callback mutations do not hide losses, and leave unsampled spans and intentional null drops uncounted. Add regression coverage for discard notifications, sampling states, and intentional drops while preserving request and span completion behavior. Refs #6167 Co-Authored-By: Claude <noreply@anthropic.com>

Clarify that SDK-owned backfilling processors must also use the Sentry processor marker so callback error handling can identify their ownership. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Record attached profiles as lost when transaction event processors or beforeSendTransaction intentionally discard the transaction. Keep client reports and discard callbacks aligned with dropped profile payloads. Co-Authored-By: Claude <noreply@anthropic.com>

…iscard-reason fix(core): [Callback Errors 1] Report callback failures

Record callback_error/replay when beforeErrorSampling throws while the replay controller has an active replay ID. Do not report a loss when no replay is active. Refs GH-6081 Co-Authored-By: Claude <noreply@anthropic.com>

Bring the stack onto the latest main changes, including CI resource and test-duration fixes. Co-Authored-By: Claude <noreply@anthropic.com>

Propagate the latest main and callback error base changes through the stacked pull request. Co-Authored-By: Claude <noreply@anthropic.com>

Propagate the latest main and preceding callback error changes through the stacked pull request. Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2026-10-08T09:59:43Z


 ### Fixes

+- Fix SDK callback error handling ([#6140](https://github.com/getsentry/sentry-java/pull/6140))


🚫 The changelog entry seems to be part of an already released section ## 8.59.0.
Consider moving the entry to the ## Unreleased section, please.

Propagate the latest main and preceding callback error changes through the stacked pull request. Co-Authored-By: Claude <noreply@anthropic.com>

…rocessor-marker ref(core): [Callback Errors 2] Mark SDK-owned event processors

…vent-processors fix(core): [Callback Errors 3] Drop failed processor data

…ustom-callbacks fix(integrations): [Callback Errors 9] Guard custom callbacks

…readcrumbs fix(core): [Callback Errors 4] Drop failed breadcrumbs

…races-sampler fix(core): [Callback Errors 5] Handle tracesSampler failures

…rofiles-sampler fix(core): [Callback Errors 6] Handle profilesSampler failures

…eplay-sampling fix(core): [Callback Errors 7] Handle replay sampling failures

…rofile-accounting fix(core): [Callback Errors 8] Report dropped profiles

collection: callback error handling

468abd9

adinauer mentioned this pull request Sep 22, 2026

fix(core): [Callback Errors 1] Report callback failures #6141

Merged

6 of 9 tasks

adinauer mentioned this pull request Sep 22, 2026

fix(core): [Callback Errors 3] Drop failed processor data #6142

Merged

5 of 9 tasks

adinauer mentioned this pull request Sep 22, 2026

fix(core): [Callback Errors 4] Drop failed breadcrumbs #6143

Merged

5 of 9 tasks

adinauer mentioned this pull request Sep 24, 2026

ref(core): [Callback Errors 2] Mark SDK-owned event processors #6162

Merged

4 of 9 tasks

adinauer and others added 5 commits September 24, 2026 14:50

Merge SDK processor marker into processor callback handling

8b3c3fa

Make the preceding marker PR available to the processor failure policy. Preserve the existing stack commits and leave failure behavior unchanged. Co-Authored-By: Claude <noreply@anthropic.com>

Merge processor stack update into breadcrumb callback handling

aa17ea5

Carry the inserted SDK processor marker forward through the adjacent stack branch without rewriting existing history or changing breadcrumb behavior. Co-Authored-By: Claude <noreply@anthropic.com>

chore(core): Sync processor fixes into breadcrumb stack

8a06fde

Merge #6142 forward into #6143 so SDK-owned processor failures preserve\ntelemetry throughout the stack. Keep the breadcrumb-only diff unchanged\nand retain both changelog entries without rewriting existing history.

adinauer mentioned this pull request Sep 24, 2026

fix(core): [Callback Errors 5] Handle tracesSampler failures #6163

Merged

4 of 9 tasks

adinauer and others added 2 commits September 24, 2026 15:49

changelog

60d1e15

Link the tracesSampler failure fallback entry to #6163 in the callback error handling stack.

adinauer mentioned this pull request Sep 24, 2026

fix(core): [Callback Errors 6] Handle profilesSampler failures #6164

Merged

4 of 9 tasks

adinauer and others added 2 commits September 24, 2026 16:35

changelog

aa15164

Link the profilesSampler failure handling entry to #6164 in the callback error handling stack.

adinauer mentioned this pull request Sep 24, 2026

fix(core): [Callback Errors 7] Handle replay sampling failures #6165

Merged

4 of 9 tasks

adinauer and others added 2 commits September 24, 2026 16:53

changelog

b62c094

Link the beforeErrorSampling failure entry to PR #6165. Co-Authored-By: Claude <noreply@anthropic.com>

adinauer mentioned this pull request Sep 25, 2026

fix(core): [Callback Errors 8] Report dropped profiles #6166

Merged

4 of 9 tasks

adinauer and others added 2 commits September 25, 2026 05:49

changelog

7a471df

Link the transaction profile loss accounting entry to PR #6166. Co-Authored-By: Claude <noreply@anthropic.com>

adinauer mentioned this pull request Sep 25, 2026

fix(integrations): [Callback Errors 9] Guard custom callbacks #6167

Merged

4 of 9 tasks

changelog

44ed7c6

Link the Android capture and integration beforeSpan callback fixes to Callback Errors 9 (#6167). Co-Authored-By: Claude <noreply@anthropic.com>

linear-code Bot mentioned this pull request Sep 25, 2026

Align callback error handling with other SDKs #6081

Open

adinauer and others added 6 commits September 25, 2026 10:46

chore: Sync sampler fixes into replay sampling branch

d11680e

Merge #6164 forward into #6165 without rewriting stack history. Retain replay sampling changes and the updated trace-sampler changelog. Refs #6165 Co-Authored-By: Claude <noreply@anthropic.com>

chore: Sync sampler fixes into profile accounting branch

425a6b1

Merge #6165 forward into #6166 without rewriting stack history. Preserve attached-profile loss accounting alongside the sampler fixes. Refs #6166 Co-Authored-By: Claude <noreply@anthropic.com>

adinauer mentioned this pull request Sep 28, 2026

feat(callbacks): [Callback Errors Optional Addon] Add opt-in strict callback mode #6173

Draft

4 of 9 tasks

adinauer and others added 9 commits October 5, 2026 15:19

docs(core): Document SDK backfilling processor marker

0414429

Clarify that SDK-owned backfilling processors must also use the Sentry processor marker so callback error handling can identify their ownership. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Merge pull request #6141 from getsentry/fix/callback-error-handling-d…

9ef9efd

…iscard-reason fix(core): [Callback Errors 1] Report callback failures

fix(core): Report replay sampling callback errors

518d48a

Record callback_error/replay when beforeErrorSampling throws while the replay controller has an active replay ID. Do not report a loss when no replay is active. Refs GH-6081 Co-Authored-By: Claude <noreply@anthropic.com>

chore: Merge main into callback error stack

7fd012e

Bring the stack onto the latest main changes, including CI resource and test-duration fixes. Co-Authored-By: Claude <noreply@anthropic.com>

chore: Merge callback error base into processor marker

4916a15

Propagate the latest main and callback error base changes through the stacked pull request. Co-Authored-By: Claude <noreply@anthropic.com>

chore: Merge processor marker into event processor handling

38bf38c

Propagate the latest main and preceding callback error changes through the stacked pull request. Co-Authored-By: Claude <noreply@anthropic.com>

chore: Merge event processor handling into breadcrumbs

4d44b53

Propagate the latest main and preceding callback error changes through the stacked pull request. Co-Authored-By: Claude <noreply@anthropic.com>

chore: Merge breadcrumb handling into trace sampling

15cc695

Propagate the latest main and preceding callback error changes through the stacked pull request. Co-Authored-By: Claude <noreply@anthropic.com>

github-actions Bot reviewed Oct 8, 2026

View reviewed changes

adinauer and others added 12 commits October 8, 2026 11:59

chore: Merge trace sampling into profile sampling

97cd7e2

Propagate the latest main and preceding callback error changes through the stacked pull request. Co-Authored-By: Claude <noreply@anthropic.com>

chore: Merge profile sampling into replay sampling

287418b

Propagate the latest main and preceding callback error changes through the stacked pull request. Co-Authored-By: Claude <noreply@anthropic.com>

chore: Merge replay sampling into profile accounting

92968ab

Propagate the latest main and preceding callback error changes through the stacked pull request. Co-Authored-By: Claude <noreply@anthropic.com>

chore: Merge profile accounting into custom callbacks

e87fddf

Propagate the latest main and preceding callback error changes through the stacked pull request. Co-Authored-By: Claude <noreply@anthropic.com>

Merge pull request #6162 from getsentry/fix/callback-error-handling-p…

0b922a6

…rocessor-marker ref(core): [Callback Errors 2] Mark SDK-owned event processors

Merge pull request #6142 from getsentry/fix/callback-error-handling-e…

dea8dbc

…vent-processors fix(core): [Callback Errors 3] Drop failed processor data

Merge pull request #6167 from getsentry/fix/callback-error-handling-c…

64c1c55

…ustom-callbacks fix(integrations): [Callback Errors 9] Guard custom callbacks

Merge pull request #6143 from getsentry/fix/callback-error-handling-b…

75338f5

…readcrumbs fix(core): [Callback Errors 4] Drop failed breadcrumbs

Merge pull request #6163 from getsentry/fix/callback-error-handling-t…

b692e97

…races-sampler fix(core): [Callback Errors 5] Handle tracesSampler failures

Merge pull request #6164 from getsentry/fix/callback-error-handling-p…

5b0d221

…rofiles-sampler fix(core): [Callback Errors 6] Handle profilesSampler failures

Merge pull request #6165 from getsentry/fix/callback-error-handling-r…

136073f

…eplay-sampling fix(core): [Callback Errors 7] Handle replay sampling failures

Merge pull request #6166 from getsentry/fix/callback-error-handling-p…

dfb67ed

…rofile-accounting fix(core): [Callback Errors 8] Report dropped profiles

Navigation Menu

Repository navigation

fix(core): Handle callback errors - #6140

fix(core): Handle callback errors#6140
adinauer wants to merge 46 commits into
mainfrom
fix/callback-error-handling

adinauer commented Sep 22, 2026 •

edited

Loading

Uh oh!

sentry Bot commented Sep 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot Oct 8, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant


		### Fixes

		- Fix SDK callback error handling ([#6140](https://github.com/getsentry/sentry-java/pull/6140))

Conversation

adinauer commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Stack (Callback Errors)

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

sentry Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📲 Install Builds

Android

Uh oh!

github-actions Bot Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

adinauer commented Sep 22, 2026 •

edited

Loading

sentry Bot commented Sep 22, 2026 •

edited

Loading