perf(core): Detect Sentry executor thread without a name scan#5691
Draft
runningcode wants to merge 1 commit into
Draft
perf(core): Detect Sentry executor thread without a name scan#5691runningcode wants to merge 1 commit into
runningcode wants to merge 1 commit into
Conversation
PersistingScopeObserver.serializeToDisk gated the on-executor fast path by scanning Thread.currentThread().getName(), which allocates a String and scans it on every scope mutation (breadcrumb, tag, trace, ...). Tag the executor threads with a marker Thread subclass and expose an allocation-free SentryExecutorService.isSentryExecutorThread() check instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
9140184 to
2c5fa85
Compare
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abfcc92 | 304.04 ms | 370.33 ms | 66.29 ms |
| 4e3e79d | 365.83 ms | 477.62 ms | 111.79 ms |
| d8912da | 329.94 ms | 389.68 ms | 59.74 ms |
| d15471f | 294.13 ms | 399.49 ms | 105.36 ms |
| abf451a | 332.82 ms | 403.67 ms | 70.85 ms |
| 604a261 | 380.65 ms | 451.27 ms | 70.62 ms |
| 806307f | 357.85 ms | 424.64 ms | 66.79 ms |
| 22f4345 | 307.87 ms | 354.51 ms | 46.64 ms |
| d217708 | 375.27 ms | 415.68 ms | 40.41 ms |
| c3ee041 | 310.64 ms | 361.90 ms | 51.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| 4e3e79d | 0 B | 0 B | 0 B |
| d8912da | 0 B | 0 B | 0 B |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| abf451a | 1.58 MiB | 2.20 MiB | 635.29 KiB |
| 604a261 | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| 806307f | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| c3ee041 | 0 B | 0 B | 0 B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JAVA-607.
Description
PersistingScopeObserver.serializeToDiskdecided whether it was already on the Sentry executor thread by scanning the thread name:Thread.getName()allocates a freshStringand.contains()scans it — on every scope mutation (breadcrumb, tag, trace, user, …), including on the main thread as the synchronous part ofaddBreadcrumb.This tags the executor threads with a package-private marker
Threadsubclass (thread name unchanged) and adds an allocation-freeSentryExecutorService.isSentryExecutorThread()check used in its place.API
Adds one method to the already
@ApiStatus.InternalSentryExecutorService;apiDumpregenerated (single-line.apiaddition).Source
Found via on-device Perfetto method-trace analysis of the Android SDK scope-persistence path (~3,130 scope stores go through this gate). Part of Reduce SDK init time [Android].
🤖 Generated with Claude Code