feat(extend-app-start): [1/4] Add IAppStartExtender bridge by buenaflor · Pull Request #5605 · getsentry/sentry-java

buenaflor · 2026-06-23T11:17:08Z

PR Stack (Extend App Start)

📜 Description

Adds the naming-stable core contract for the app start extension API:

IAppStartExtender (@ApiStatus.Internal) + a NoOpAppStartExtender default.
Wired into SentryOptions via a getter/setter, mirroring fullyDisplayedReporter.

Inert until later PRs — returns NoOpSpan / no-ops until the Android implementation ([2/4]) and the public Sentry facade ([4/4]) land. Splitting the contract from the machinery keeps the API naming isolated and easy to review.

💡 Motivation and Context

First PR of the stack implementing the app start extension API (part of #5553), which lets apps extend the app start measurement to cover extra launch-time work (mirrors sentry-cocoa's extendAppLaunch()). Splitting into stacked PRs keeps each change small and reviewable.

💚 How did you test it?

Unit tests (TDD):

SentryOptionsTest — default appStartExtender is NoOpAppStartExtender; setter works.
NoOpAppStartExtenderTest — singleton; getExtendedAppStartSpan() returns NoOpSpan; extendAppStart() / finishAppStart() no-op.

./gradlew :sentry:apiCheck :sentry:spotlessJavaCheck :sentry:spotlessKotlinCheck pass.

📝 Checklist

I added GH Issue ID & Linear ID
I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[2/4] — extract the AppStartExtension component in sentry-android-core.

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

#skip-changelog

github-actions · 2026-06-23T11:17:43Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b8779ca

sentry · 2026-06-23T11:20:40Z

📲 Install Builds

Android

🔗 App Name	App ID	Version	Configuration
SDK Size	io.sentry.tests.size	8.46.0 (1)	release

⚙️ sentry-android Build Distribution Settings

github-actions · 2026-06-23T11:41:15Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	325.84 ms	388.88 ms	63.04 ms
Size	0 B	0 B	0 B

Previous results on branch: feat/app-start-extension-core

Startup times

Revision	Plain	With Sentry	Diff
`3d04aae`	324.42 ms	359.30 ms	34.88 ms
`69d43cc`	380.70 ms	424.90 ms	44.20 ms
`2821a4d`	315.46 ms	366.56 ms	51.10 ms

App size

Revision	Plain	With Sentry	Diff
`3d04aae`	0 B	0 B	0 B
`69d43cc`	0 B	0 B	0 B
`2821a4d`	0 B	0 B	0 B

…s wiring Introduces the @ApiStatus.Internal IAppStartExtender contract (extendAppStart / finishAppStart / getExtendedAppStartSpan) and a NoOp default, wired into SentryOptions. This is the naming-stable core bridge for the app start extension API; it is inert (returns NoOpSpan / no-ops) until the Android implementation and public Sentry facade land later in the stack. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

buenaflor · 2026-06-23T12:22:12Z

+class NoOpAppStartExtenderTest {
+  private val extender = NoOpAppStartExtender.getInstance()
+
+  @Test fun `extendAppStart does not throw`() = extender.extendAppStart()
+
+  @Test fun `finishAppStart does not throw`() = extender.finishAppStart()
+
+  @Test
+  fun `getExtendedAppStartSpan returns NoOpSpan`() {
+    assertSame(NoOpSpan.getInstance(), extender.extendedAppStartSpan)
+  }
+}


following conventions of existing no-op class tests, lmk if we dont need this

I would remove this. I don't see a benefit and the downside is that it increases test duration.

Copilot

Pull request overview

Adds the core (internal) bridge for the upcoming “extend app start” feature by introducing an IAppStartExtender contract with a default no-op implementation and wiring it into SentryOptions. This establishes stable naming in the core SDK while keeping the feature inert until Android/public facade PRs land later in the stack.

Changes:

Add IAppStartExtender (@ApiStatus.Internal) and NoOpAppStartExtender default implementation.
Wire appStartExtender into SentryOptions with an internal getter/setter and default to the no-op.
Add unit tests for the new option default/setter behavior and for the no-op extender behavior; update sentry.api.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
sentry/src/main/java/io/sentry/SentryOptions.java	Adds `appStartExtender` field + `@ApiStatus.Internal` getter/setter with default no-op implementation.
sentry/src/main/java/io/sentry/IAppStartExtender.java	Introduces the internal contract bridging future `Sentry.extendAppStart()`-style APIs to platform implementation.
sentry/src/main/java/io/sentry/NoOpAppStartExtender.java	Adds default no-op implementation returning `NoOpSpan` and no-op lifecycle methods.
sentry/src/test/java/io/sentry/SentryOptionsTest.kt	Verifies `SentryOptions` defaults to `NoOpAppStartExtender` and returns a custom extender when set.
sentry/src/test/java/io/sentry/NoOpAppStartExtenderTest.kt	Tests singleton/no-throw behavior and that the extended span is `NoOpSpan`.
sentry/api/sentry.api	Updates API dump to include the new types and `SentryOptions` accessor methods.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ix test name typo Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…pStart Mirrors sentry-cocoa's finishExtendedAppLaunch() and makes the API name explicit about finishing the *extended* app start. Renames IAppStartExtender.finishAppStart() and the NoOpAppStartExtender implementation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

… inactive Mirrors Sentry.getSpan(): the extender reports null when there is no active extended span instead of a NoOpSpan, so callers can tell there is no span running. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

runningcode · 2026-07-02T13:28:08Z

+ * that don't provide an app start measurement.
+ */
+@ApiStatus.Internal
+public interface IAppStartExtender {


Not related to your PR, but I wish we had an internal package where we can put things that we don't want customers to use. I know there is the @ApiStatus.Internal annotation already but I think have the package would also help organize the code better.

This was referenced Jun 23, 2026

feat(extend-app-start): App start extension API #5604

Draft

feat(extend-app-start): [2/4] Extract AppStartExtension component #5606

Open

buenaflor force-pushed the feat/app-start-extension-core branch from 064d3f1 to 7a7d63f Compare June 23, 2026 12:13

buenaflor marked this pull request as ready for review June 23, 2026 12:21

buenaflor requested review from adinauer and romtsn as code owners June 23, 2026 12:21

Copilot AI review requested due to automatic review settings June 23, 2026 12:21

buenaflor requested review from 0xadam-brown, markushi and runningcode as code owners June 23, 2026 12:21

Copilot started reviewing on behalf of buenaflor June 23, 2026 12:21 View session

buenaflor commented Jun 23, 2026

View reviewed changes

Copilot AI reviewed Jun 23, 2026

View reviewed changes

Comment thread sentry/src/main/java/io/sentry/NoOpAppStartExtender.java

Comment thread sentry/src/test/java/io/sentry/SentryOptionsTest.kt Outdated

buenaflor mentioned this pull request Jun 23, 2026

feat(extend-app-start): [3/4] Eagerly create the extended app start transaction #5608

Open

8 tasks

chore(extend-app-start): Annotate NoOpAppStartExtender internal and f…

313fff1

…ix test name typo Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

buenaflor mentioned this pull request Jun 25, 2026

feat(extend-app-start): [4/4] Add public Sentry app start extension API and update example app #5628

Open

8 tasks

romtsn approved these changes Jul 2, 2026

View reviewed changes

runningcode approved these changes Jul 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(extend-app-start): [1/4] Add IAppStartExtender bridge#5605

feat(extend-app-start): [1/4] Add IAppStartExtender bridge#5605
buenaflor wants to merge 4 commits into
feat/extend-app-startfrom
feat/app-start-extension-core

buenaflor commented Jun 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 23, 2026 •

edited

Loading

Uh oh!

sentry Bot commented Jun 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 23, 2026 •

edited

Loading

Previous results on branch: feat/app-start-extension-core

Startup times

App size

Uh oh!

buenaflor Jun 23, 2026

Uh oh!

runningcode Jul 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

runningcode Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

buenaflor commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Stack (Extend App Start)

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sentry Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📲 Install Builds

Android

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Previous results on branch: feat/app-start-extension-core

Startup times

App size

Uh oh!

buenaflor Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

runningcode Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

runningcode Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

buenaflor commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

sentry Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading