docs(js): Remove the Connect guide and redirect it to Node - #19371
Draft
JPeer264 wants to merge 1 commit into
Draft
docs(js): Remove the Connect guide and redirect it to Node#19371JPeer264 wants to merge 1 commit into
JPeer264 wants to merge 1 commit into
Conversation
v11 removed the Connect instrumentation, so `@sentry/node` exports neither `setupConnectErrorHandler` nor `connectIntegration`, and every app the guide printed crashed with `TypeError: Sentry.setupConnectErrorHandler is not a function` before it listened. Nothing Connect specific is left to document. A Connect app is still instrumented by the generic Node HTTP instrumentation, so the Node guide covers it, and the guide now redirects there. - Delete the Connect guide, the Connect integration page and the eleven Connect only platform includes. - Drop `javascript.connect` from the frontmatter and `PlatformSection` lists of 117 pages, and from the Logs and Metrics platform pickers. - Drop Connect from the request handler row of the span op table, in the migration page and in its include. - Drop `connect` from the `frameworks` list of ten v11 migration items, which `scripts/validate-migration-items.mjs` validates against the guide directory. - Point the React Native `RequestData` link at the Node guide. - Redirect `/platforms/javascript/guides/connect/` and everything under it to the Node guide. The v8 migration pages keep their `connectIntegration` mentions, since they record what v8 shipped. Refs SDK-1498 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
| Source | Current Destination | Should Be | File |
|---|---|---|---|
/clients/node/integrations/connect/ |
/platforms/javascript/guides/connect/ |
/platforms/javascript/guides/node/ |
middleware.ts |
/platforms/node/connect/ |
/platforms/javascript/guides/connect/ |
/platforms/javascript/guides/node/ |
middleware.ts |
Each redirect hop loses ~15% of SEO link equity and adds latency for users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT
When we merge this we redirect
/connectto/nodewith a permanent redirect. That means if in the future we'll readd/connectwe have to choose another name because connect has a permanent redirect. Everyone that has that in their browser cache has it in there forever.DESCRIBE YOUR PR
closes SDK-1498
v11 removed the Connect instrumentation, so
@sentry/nodeexports neithersetupConnectErrorHandlernorconnectIntegration, and every app the guide printed crashed withTypeError: Sentry.setupConnectErrorHandler is not a functionbefore it listened.Nothing Connect specific is left to document. A Connect app is still instrumented by the generic Node HTTP instrumentation, so the Node guide covers it, and the guide now redirects there.
javascript.connectfrom the frontmatter andPlatformSectionlists of 117 pages, and from the Logs and Metrics platform pickers.connectfrom theframeworkslist of ten v11 migration items, whichscripts/validate-migration-items.mjsvalidates against the guide directory.RequestDatalink at the Node guide./platforms/javascript/guides/connect/and everything under it to the Node guide.The v8 migration pages keep their
connectIntegrationmentions, since they record what v8 shipped.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES