Update SSO configuration instructions#17538
Open
LordSimal wants to merge 2 commits intogetsentry:masterfrom
Open
Update SSO configuration instructions#17538LordSimal wants to merge 2 commits intogetsentry:masterfrom
LordSimal wants to merge 2 commits intogetsentry:masterfrom
Conversation
|
@LordSimal is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
Added note about redirect URL and installation script.
Added instructions for enabling Google Provider and re-running install script after configuration changes.
|
|
||
| The redirect URL should be `${url-prefix}/auth/sso/`. | ||
|
|
||
| After that you need to go into your Organization Settings => Organization => Auth and enable the Google Provider. |
There was a problem hiding this comment.
Bug: The navigation path Organization Settings => Organization => Auth is incorrect. The correct path to Sentry's Auth settings is Org Settings > Auth.
Severity: LOW
Suggested Fix
Update the navigation path in sso.mdx to Org Settings > Auth to match the actual UI and other documentation. The URL can also be provided for clarity: /settings/ORG_SLUG/auth/.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: develop-docs/self-hosted/configuration/sso.mdx#L42
Potential issue: The documentation provides an incorrect navigation path for accessing
SSO settings: `Organization Settings => Organization => Auth`. The intermediate `=>
Organization =>` step does not exist in the Sentry UI. The correct path is `Org Settings
> Auth`, as confirmed by other documentation files. This error will prevent users from
finding the authentication settings page, hindering their ability to configure SSO.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added note about redirect URL and installation script.
DESCRIBE YOUR PR
It was not clear from the get go what redirect URL should be used when using Google SSO. This adds a separate sentence to clarify it.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES