Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
logaretm
force-pushed
the
awad/nitro-sdk
branch
from
7f00563 to
ca92a79
Compare
logaretm
requested review from
a team,
inventarSarah and
s1gr1d
and removed request for
s1gr1d
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial documentation and UI support for the new Nitro JavaScript SDK within the docs site, including platform icon support and platform-specific source maps guidance.
Changes:
- Add Nitro platform icon mappings (
nitro+javascript-nitro) to the platform icon component. - Add a new Nitro guide page (
/platforms/javascript/guides/nitro/) and Nitro-specific source maps include content. - Bump
platformiconsdependency to a version which includes the Nitro icon assets.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/platformIcon.tsx | Adds Nitro SVG imports and maps javascript-nitro to the Nitro icon. |
| package.json | Updates platformicons to ^9.4.0 to pick up Nitro icon assets. |
| pnpm-lock.yaml | Lockfile updates reflecting the dependency bump (plus additional transitive changes). |
| platform-includes/sourcemaps/primer/javascript.nitro.mdx | Adds Nitro-specific source maps “primer” include content. |
| platform-includes/sourcemaps/overview/javascript.nitro.mdx | Adds Nitro-specific source maps “overview” include content (includes troubleshooting link). |
| docs/platforms/javascript/guides/nitro/index.mdx | Adds the main Nitro SDK setup/feature guide page. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
|
|
||
| ### Troubleshooting | ||
|
|
||
| If you're experiencing issues with source maps, see [Troubleshooting Source Maps](/platforms/javascript/guides/nitro/troubleshooting/). |
Comment on lines
+263
to
+264
| - Learn how to <PlatformLink to="/usage">manually capture errors</PlatformLink> | ||
| - Continue to <PlatformLink to="/configuration">customize your configuration</PlatformLink> |
|
|
||
| <Expandable permalink={false} title="Are you having problems setting up the SDK?"> | ||
|
|
||
| - Find various topics in <PlatformLink to="/troubleshooting">Troubleshooting</PlatformLink> |
Comment on lines
3925
to
3930
| '@types/node@22.19.11': | ||
| resolution: {integrity: sha512-BH7YwL6rA93ReqeQS1c4bsPpcfOmJasG+Fkr6Y59q83f9M1WcBRHR2vM+P9eOisYRcN3ujQoiZY8uk5W+1WL8w==} | ||
|
|
||
| '@types/node@22.19.15': | ||
| resolution: {integrity: sha512-F0R/h2+dsy5wJAUe3tAU6oqa2qbWY5TpNfL/RGmo1y38hiyO1w3x2jPtt76wmuaJI4DQnOBu21cNXQ2STIUUWg==} | ||
| '@types/node@22.19.17': | ||
| resolution: {integrity: sha512-wGdMcf+vPYM6jikpS/qhg6WiqSV/OhG+jeeHT/KlVqxYfD40iYJf9/AE1uQxVWFvU7MipKRkRv8NSHiCGgPr8Q==} | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Nitro SDK docs, it was released in
10.51.0IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.