Skip to content

Coolguyzone/feat/monitors guide#17433

Open
coolguyzone wants to merge 4 commits into
masterfrom
coolguyzone/feat/monitors-guide
Open

Coolguyzone/feat/monitors guide#17433
coolguyzone wants to merge 4 commits into
masterfrom
coolguyzone/feat/monitors-guide

Conversation

@coolguyzone
Copy link
Copy Markdown
Contributor

@coolguyzone coolguyzone commented Apr 21, 2026

DESCRIBE YOUR PR

See new guides!
https://sentry-docs-git-coolguyzone-featmonitors-guide.sentry.dev/guides/alerts/
https://sentry-docs-git-coolguyzone-featmonitors-guide.sentry.dev/guides/monitors/

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sentry-docs Ready Ready Preview, Comment May 7, 2026 10:39pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
develop-docs Ignored Ignored Preview May 7, 2026 10:39pm

Request Review

Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx Outdated
@sfanahata
Copy link
Copy Markdown
Contributor

sfanahata commented Apr 25, 2026

@coolguyzone I think you're still referencing old UX. Can you take another pass at the current UX? You can find that in the demo org.

@rahulchhabria
Copy link
Copy Markdown
Contributor

@coolguyzone - i think the products been updated already. i see the new exp in my personal org. any update on when we'll merge these changes? looks like there are a handful of open comments that need to be resolved too.

@coolguyzone
Copy link
Copy Markdown
Contributor Author

@rahulchhabria Yep, apparently there was a new UI I didn't catch, so I'll have to give these a big makeover, probably a day or two. Let me know if this is blocking.

@rahulchhabria
Copy link
Copy Markdown
Contributor

@coolguyzone - probably need it sooner than later since we moved a lot of cheese.

@coolguyzone
Copy link
Copy Markdown
Contributor Author

coolguyzone commented Apr 28, 2026

@rahulchhabria Gotcha, I'm assuming we want to time this with the release of the new UI, do we know the timing for that?

edit: Or I suppose we could just put an EA tag on these guides and merge them sooner.

@coolguyzone coolguyzone force-pushed the coolguyzone/feat/monitors-guide branch from 38dfb3d to 3e495b1 Compare April 28, 2026 21:34
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/monitors.mdx Outdated
@sfanahata
Copy link
Copy Markdown
Contributor

@coolguyzone - probably need it sooner than later since we moved a lot of cheese.

Not blocking anything. All docs have been updated re: monitors and alerts. But Allison and Nick would love these guides while EA is still happening. GA date is still TBD. Let me know if you want to chat through any of it! cc @rahulchhabria

Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/alerts.mdx
Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/monitors.mdx Outdated
Comment thread docs/guides/monitors.mdx Outdated
Comment thread docs/guides/monitors.mdx Outdated
Comment thread docs/guides/monitors.mdx Outdated
Comment thread docs/guides/monitors.mdx Outdated
@sfanahata
Copy link
Copy Markdown
Contributor

@coolguyzone - I made some chunky format suggestions on the Monitors guide for the examples. I think breaking them out and using terminology that's in the UX would help people "quick start" their own custom Monitors.

Open to more thoughts on these, @souredoutlook

Comment thread docs/guides/alerts.mdx Outdated
Comment thread docs/guides/monitors.mdx Outdated
Comment thread docs/guides/alerts.mdx
Comment thread docs/ai/index.mdx
Comment thread src/components/skipToContent.tsx
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
coolguyzone and others added 3 commits May 7, 2026 15:26
Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com>
Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com>
Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com>
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1001a76. Configure here.

Comment thread docs/guides/monitors.mdx
| Notification delivery job | Cron | Schedule: every 2 min; max runtime: 90 sec | `#platform-eng` |
| API base endpoint | Uptime | Probe: every 1 min; failure threshold: 3 consecutive | `#oncall` |
| Payment error rate | Metric | Signal: error rate on checkout/billing spans; detection: absolute; threshold: > 1% in 5 min window | `#billing-eng` |
**Cron Monitors:**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SaaS section has duplicated monitor summary tables

Medium Severity

The SaaS walkthrough has a "Key monitors to set up" summary table (listing all 7 monitors with Type/Configuration/Owner) immediately followed by separate detailed "Cron Monitors", "Metric Monitors", and "Uptime Monitors" tables covering the exact same monitors with more detail. The Gaming and Mobile sections only use the detailed per-type tables. The summary table appears to be leftover content that wasn't removed when the detailed breakdowns were added during review feedback. This creates confusing redundancy for readers.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 1001a76. Configure here.

Comment thread docs/guides/monitors.mdx
Comment on lines +157 to +158
| Payment error rate | Metric | Signal: error rate on checkout/billing spans; detection: absolute; threshold: > 1% in 5 min window | `#billing-eng` |
**Cron Monitors:**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: A blank line is missing between a table and the following heading on line 158. This violates the established formatting pattern in the file and can cause rendering issues.
Severity: LOW

Suggested Fix

Add a blank line between the end of the table on line 157 and the **Cron Monitors:** heading on line 158. This will make the formatting consistent with the rest of the document and ensure correct rendering across different MDX parsers.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: docs/guides/monitors.mdx#L157-L158

Potential issue: In `docs/guides/monitors.mdx`, the table ending on line 157 is
immediately followed by the `**Cron Monitors:**` heading on line 158 without a
separating blank line. This is inconsistent with all other table-to-heading transitions
within the same file, which include a blank line. While some MDX parsers might render
this correctly, it violates the established pattern and goes against best practices for
MDX, which recommend blank lines around tables to ensure reliable parsing and prevent
potential rendering issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants