Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f7efadb. Configure here.
f7efadb to
f53be24
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3945 +/- ##
==========================================
+ Coverage 87.95% 92.46% +4.51%
==========================================
Files 347 114 -233
Lines 12930 4391 -8539
==========================================
- Hits 11372 4060 -7312
+ Misses 1558 331 -1227
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
6d63ec5 to
997c7fa
Compare
997c7fa to
408f18e
Compare
Building the Flutter example and running the Dart e2e suite each required remembering raw shell commands buried in scripts and CI config. Wrap them as melos scripts so `melos run --list` surfaces them, and document the common ones in CONTRIBUTING.md. Also fixes a latent bug in run.sh where calling it with no arguments crashed on an unbound variable instead of printing usage.
Melos runs scripts through cmd.exe on Windows, which can't execute run.sh, so the windows platform arg was never reachable there.
buenaflor noted the Dart e2e test is slated for removal, so a melos convenience wrapper for it isn't worth adding right now.
408f18e to
5bfb47a
Compare

📜 Description
Adds two melos scripts:
melos run example:flutter -- <platform>— builds and runs the Flutter example app (delegates to the existingpackages/flutter/example/run.sh, so there's still one source of truth for the build logic).melos run e2e:dart— runs the Dart e2e suite against sentry.io (mirrors.github/workflows/e2e_dart.yml, requiresSENTRY_AUTH_TOKEN_E2Elocally).Also documents the existing and new scripts in a "Common commands" table in
CONTRIBUTING.md, and fixes a small bug inrun.shwhere calling it with no arguments crashed on an unbound variable (set -u) instead of printing the usage message.💡 Motivation and Context
Closes #3660
Building the example app and running the e2e suite both require remembering raw shell commands that live in a few different places (
run.sh, CI workflow files). This wraps them behindmelos run, which is discoverable viamelos run --list.I kept this scoped to the two examples the issue calls out rather than guessing at everything "and so on" might cover.
💚 How did you test it?
melos run example:flutter -- ""to confirm the script forwards args correctly and the run.sh usage guard fires as expected.melos run e2e:dartto confirm it resolves dependencies and fails fast with a clear error whenSENTRY_AUTH_TOKEN_E2Eisn't set (same behavior as CI without the secret).bash -n packages/flutter/example/run.shto sanity check the shell syntax.📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
If there's appetite for it, a follow-up could tighten
test:dart/test:flutter/analyze:*to match the flags CI actually uses (randomized test ordering, web/wasm runs,--fatal-infos), since those currently drift from what CI checks.