Skip to content

feat(attributes): Add Hapi attributes hapi.type, hapi.plugin.name, and hapi.ext.type - #741

Merged
s1gr1d merged 3 commits into
mainfrom
sig/hapi-conventions
Oct 23, 2026
Merged

s1gr1d merged 3 commits into
mainfrom
sig/hapi-conventions

Conversation

@s1gr1d

@s1gr1d s1gr1d commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Description

The Hapi instrumentation in the JavaScript SDK already sends hapi.type, hapi.plugin.name, and server.ext.type. The names come from the OpenTelemetry contrib package instrumentation-hapi. They are not in the OTel semantic conventions.

  • hapi.type and hapi.plugin.name keep their names. hapi.type follows koa.type.
  • server.ext.type is in the wrong namespace. In OTel and in these conventions, server.* describes the network endpoint of the server. This PR adds hapi.ext.type as the replacement and deprecates server.ext.type.

The JavaScript SDK will send both names until the next major version, then only hapi.ext.type.

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I have used the correct value for apply_scrubbing (i.e. manual or auto. Use never only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

Add `hapi.type`, `hapi.plugin.name` and `hapi.ext.type`, and
`server.ext.type` as deprecated in favor of `hapi.ext.type`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-conventions Ready Ready Preview Oct 23, 2026 9:41am UTC

Request Review

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add Hapi attributes hapi.type, hapi.plugin.name, and hapi.ext.type by s1gr1d in #741
  • Add experimental gen_ai.extract operation by andreiborza in #728
  • Remove next_trace from the sentry.link.type values by s1gr1d in #739
  • Add server_request as a sentry.link.type value by s1gr1d in #738
  • Add LCP and INP subpart attributes by logaretm in #712
  • Add message_origin as a sentry.link.type value by JPeer264 in #724
  • Add aws.lambda.resource_mapping.id attribute by pabloDeputter in #710
  • Add object to the sentry.category values by pabloDeputter in #721
  • Add http.request.duration by loewenheim in #697

Names

  • Add span name rules for rpc spans by pabloDeputter in #714
  • Add queue.publish/create/receive/process/settle to messaging span names by pabloDeputter in #705

Other

  • (descriptions) AWS Lambda function descriptions by pabloDeputter in #720
  • (docs) Add metrics page by logaretm in #733
  • (gen_ai) Add tool call result size attribute by obostjancic in #679
  • (metrics) Add browser bfcache and element timing metrics by logaretm in #729
  • (ops) Add object.copy op by pabloDeputter in #706
  • Add view.render op by alexander-alderman-webb in #699

Bug Fixes 🐛

  • (attributes) Apply consistent scrubbing across deprecations by mjq in #692

Documentation 📚

  • (cache) Define cache.ttl for fractional and per-read TTLs by s1gr1d in #726
  • Clarify cache.ttl for 0, no expiry, and reads by s1gr1d in #725

Internal Changes 🔧

Deps

  • Bump nanoid to 3.3.20 by Lms24 in #737
  • Bump vite from 8.2.1 to 8.3.5 by dependabot in #735
  • Bump markdown-it from 15.0.2 to 15.0.3 by dependabot in #736

Other

  • (attributes) Scrub S3 object keys by default by pabloDeputter in #713
  • (node) Bump Node to 22.23.4 by oioki in #742
  • (repo) Update CODEOWNERS to include @giortzisg by Lms24 in #708
  • Deprecate gen_ai.responses in favor of gen_ai.chat by alexander-alderman-webb in #703
  • Add deprecated messaging ops set by the Python SDK by alexander-alderman-webb in #693
  • Add view.response.render op, deprecated in favor of view.render by alexander-alderman-webb in #700
  • Add event.django op, deprecated in favor of function by alexander-alderman-webb in #698

🤖 This preview updates automatically when you update the PR.

@s1gr1d
s1gr1d marked this pull request as ready for review October 21, 2026 14:00
@s1gr1d s1gr1d changed the title feat(attributes): Add Hapi attributes feat(attributes): Add Hapi attributes hapi.type, hapi.plugin.name, and hapi.ext.type Oct 21, 2026
@s1gr1d
s1gr1d requested a review from andreiborza October 21, 2026 14:02

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call with the deprecation!

@s1gr1d
s1gr1d enabled auto-merge (squash) October 23, 2026 09:40
@s1gr1d
s1gr1d merged commit 1cbe89d into main Oct 23, 2026
17 checks passed
@s1gr1d
s1gr1d deleted the sig/hapi-conventions branch October 23, 2026 09:44
s1gr1d added a commit to getsentry/sentry-javascript that referenced this pull request Oct 23, 2026
…ds (#25527)

Hapi routes registered with several methods (`method: ['GET', 'POST']`)
returned a 500 with `traceLifecycle: 'static'`. Router spans now use the
request method. This also fixes `*` as the method on wildcard routes.

The Hapi attributes (`hapi.type`, `hapi.plugin.name`, `server.ext.type`)
are not in the [Sentry
conventions](https://getsentry.github.io/sentry-conventions/attributes)
yet.

⚠️ This conventions PR needs to be merged and released first:
getsentry/sentry-conventions#741

Fixes #25481

---------

Co-authored-by: Rahul Kashyap <itisrmk@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview — 1aebc207 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants