Repository navigation
feat(attributes): Add Hapi attributes hapi.type, hapi.plugin.name, and hapi.ext.type - #741
Merged
Merged
Conversation
Add `hapi.type`, `hapi.plugin.name` and `hapi.ext.type`, and `server.ext.type` as deprecated in favor of `hapi.ext.type`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Names
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
s1gr1d
marked this pull request as ready for review
October 21, 2026 14:00
s1gr1d
requested review from
a team,
Lms24,
alexander-alderman-webb,
cleptric,
giortzisg,
mjq and
nsdeschenes
as code owners
October 21, 2026 14:00
hapi.type, hapi.plugin.name, and hapi.ext.type
Lms24
approved these changes
Oct 22, 2026
Lms24
left a comment
Member
There was a problem hiding this comment.
Good call with the deprecation!
s1gr1d
enabled auto-merge (squash)
October 23, 2026 09:40
4 tasks done
s1gr1d
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Oct 23, 2026
…ds (#25527) Hapi routes registered with several methods (`method: ['GET', 'POST']`) returned a 500 with `traceLifecycle: 'static'`. Router spans now use the request method. This also fixes `*` as the method on wildcard routes. The Hapi attributes (`hapi.type`, `hapi.plugin.name`, `server.ext.type`) are not in the [Sentry conventions](https://getsentry.github.io/sentry-conventions/attributes) yet.⚠️ This conventions PR needs to be merged and released first: getsentry/sentry-conventions#741 Fixes #25481 --------- Co-authored-by: Rahul Kashyap <itisrmk@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Hapi instrumentation in the JavaScript SDK already sends
hapi.type,hapi.plugin.name, andserver.ext.type. The names come from the OpenTelemetry contrib packageinstrumentation-hapi. They are not in the OTel semantic conventions.hapi.typeandhapi.plugin.namekeep their names.hapi.typefollowskoa.type.server.ext.typeis in the wrong namespace. In OTel and in these conventions,server.*describes the network endpoint of the server. This PR addshapi.ext.typeas the replacement and deprecatesserver.ext.type.The JavaScript SDK will send both names until the next major version, then only
hapi.ext.type.PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)apply_scrubbing(i.e.manualorauto. Useneveronly for values that should never be scrubbed such as IDs)If an attribute was deprecated: