ref: Remove experimental flag from snapshots and build commands#3329
Merged
NicoHinderling merged 1 commit intoJun 12, 2026
Merged
Conversation
The snapshots commands (upload, download, diff) and the build download command were marked experimental, printing a warning to stderr on every run and prefixing their help text with [EXPERIMENTAL]. These commands are now stable, so remove the warnings and the experimental help markers. Update the affected trycmd help fixtures accordingly.
runningcode
approved these changes
Jun 12, 2026
szokeasaurusrex
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
snapshotscommands (upload,download,diff) and thebuild downloadcommand were marked experimental. Each printed an[EXPERIMENTAL] ... subject to breaking changeswarning to stderr on every invocation and prefixed its--helptext with[EXPERIMENTAL].These commands are now stable, so this removes:
EXPERIMENTAL_WARNINGconstants and theireprintln!runtime warnings.[EXPERIMENTAL]prefixes fromabout(...)strings (including thesnapshotsparent command) and the{EXPERIMENTAL_WARNING}interpolation inlong_abouttext.Motivation
The experimental warnings added noise to every run and signaled instability that no longer applies now that these commands are supported.
Changes
src/commands/snapshots/{mod,upload,download,diff}.rs— remove warnings and experimental help markers.src/commands/build/download.rs— same forbuild download.trycmdhelp fixtures (snapshots/build help, top-level help, Windows help). Fixtures were edited by hand rather than viaTRYCMD=overwriteto preserve the[EXE]Windows-suffix placeholders.Testing
cargo build,cargo clippy(clean)cargo test --test mod— 190 passed, 0 failed