This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Only fetch context when sending exception and message#635
Open
lepture wants to merge 2 commits intogetsentry:masterfrom
Open
Only fetch context when sending exception and message#635lepture wants to merge 2 commits intogetsentry:masterfrom
lepture wants to merge 2 commits intogetsentry:masterfrom
Conversation
Member
|
I think what I'd prefer is we support passing a function to the context methods for lazy execution rather than one-offing this with each integration |
|
@dcramer is there a solution for lazy execution now? Our app metrics show that raven can be the most time-consuming process for some requests in our Flask app (especially POST requests). If there is no solution yet, I'd be happy to help if you can give me some pointers on how to implement it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
before_requestwill be called every request. It costs 10+ ms to collect contextinformation even if there is no errors.
This makes the application slow. The patch will change this behavior. It works like the tornado
plugin. It will collect context information when there is an error.