This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Improve the Processor base class and SanitizePasswordsProcessor class#521
Open
htquach wants to merge 2 commits intogetsentry:masterfrom
Open
Improve the Processor base class and SanitizePasswordsProcessor class#521htquach wants to merge 2 commits intogetsentry:masterfrom
htquach wants to merge 2 commits intogetsentry:masterfrom
Conversation
Improve Processor to also check for stacktrace at the 'data' level. A stacktrace can exist in the data even without an 'exception' key. Also added 'pw' and 'cred' to the list of FIELDS to screen for in SanitizePasswordProcessor. These two fields being used in the standard python LDAP module
Contributor
There was a problem hiding this comment.
Do we have a test that highlight why this is needed ?
Author
There was a problem hiding this comment.
Are you asking for updating the tests/processors/tests.py for case when an event that has 'stacktrace' in its data? I have just updated the processor test to include the two additional 'pw' and 'cred' field. As for the test case for 'AUTO_LOG_STACKS', I will need to spend a bit more time in figuring how to write a test for that (turn on auto_log_stacks and build a raven.events.Message).
This can be reproduce when "auto_log_stacks" option is set to True and logging a Message event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Processor to also check for stacktrace at the 'data' level. A stacktrace can exist in the data
even without an 'exception' key.
Also added 'pw' and 'cred' to the list of FIELDS to screen for in SanitizePasswordProcessor. These
two fields being used in the standard python LDAP module.