feat: add --http-header option for custom header injection#122
Open
Vignesh-285 wants to merge 2 commits intogetsentry:mainfrom
Open
feat: add --http-header option for custom header injection#122Vignesh-285 wants to merge 2 commits intogetsentry:mainfrom
Vignesh-285 wants to merge 2 commits intogetsentry:mainfrom
Conversation
Allow users to inject custom HTTP headers into all outgoing requests via a repeatable --http-header flag. This enables bypassing proxies like Cloudflare Access without adding provider-specific flags.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
- Strip http_header from telemetry args to prevent leaking secrets - Reject empty header names (e.g. ":value") - Fix tests to invoke subcommand so header parsing actually executes - Add test for empty header name validation
Vignesh-285
force-pushed
the
feat/http-header-injection
branch
from
beac0de to
45e518e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c1fa3ad. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--http-headerCLI option that injects custom HTTP headers into all outgoing requestsChanges
codecov_cli/helpers/request.py— Added_extra_headersglobal,set_extra_headers()setter, renamed_set_user_agent()→_prepare_headers()to merge extra headers while always protecting User-Agentcodecov_cli/main.py— Added--http-headeroption (multiple=True, format Header-Name:Value) with validation and parsingUsage