build: Consolidate workspace dependencies and pin explicit versions#507
Open
jan-auer wants to merge 2 commits into
Open
build: Consolidate workspace dependencies and pin explicit versions#507jan-auer wants to merge 2 commits into
jan-auer wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
lcian
reviewed
Jun 18, 2026
| # Pinned below workspace version for MSRV compatibility | ||
| reqwest = { version = "0.13.1", default-features = false, features = ["charset", "http2", "system-proxy", "json", "stream", "multipart"] } | ||
| sentry-core = { version = ">=0.41", features = ["client"] } | ||
| sentry-core = { workspace = true, features = ["client"] } |
Member
There was a problem hiding this comment.
This was intentionally specifying an open range so that the user could bring their own version and it would unify.
This way we're forcing users to either upgrade to 0.48.x, or if they don't notice, they will have 2 different versions, which means that the application and our objectstore-client will have 2 separate SDK states, meaning that this is not gonna work as intended.
Granted, we're only using this to propagate tracing headers.
Also this can probably be default-features = false now that I see it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tokiofeatures = ["full"]with the 7 features objectstore-server actually uses (fs,macros,net,rt-multi-thread,signal,sync,time)[workspace.dependencies]as a single alphabetically-sorted blockx.y→x.y.z) and align with Cargo.lock resolved versionssentry-optionsworkspace dependency