Skip to content

fix(service): Honor byte range requests in Bigtable backend#506

Open
jan-auer wants to merge 2 commits into
mainfrom
fix/bigtable-range-requests
Open

fix(service): Honor byte range requests in Bigtable backend#506
jan-auer wants to merge 2 commits into
mainfrom
fix/bigtable-range-requests

Conversation

@jan-auer

Copy link
Copy Markdown
Member

The Bigtable backend ignored the ByteRange parameter in get_tiered_object (the parameter was named _range), returning the full object with no ContentRange regardless of what the client requested. This meant clients always received 200 with the complete payload instead of 206 Partial Content.

Adds an apply_range helper that resolves the byte range against the payload and produces a zero-copy Bytes::slice, then wires it into the get_tiered_object return path.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.47%. Comparing base (c905833) to head (b7bbeec).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   87.38%   87.47%   +0.08%     
==========================================
  Files          86       86              
  Lines       13825    13912      +87     
==========================================
+ Hits        12081    12169      +88     
+ Misses       1744     1743       -1     
Components Coverage Δ
Rust Backend 92.26% <100.00%> (+0.06%) ⬆️
Rust Client 80.06% <ø> (ø)
Python Client 88.51% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-auer jan-auer marked this pull request as ready for review June 18, 2026 15:39
@jan-auer jan-auer requested a review from a team as a code owner June 18, 2026 15:39

@lcian lcian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants