fix(service): Honor byte range requests in Bigtable backend#506
Open
jan-auer wants to merge 2 commits into
Open
fix(service): Honor byte range requests in Bigtable backend#506jan-auer wants to merge 2 commits into
jan-auer wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
+ Coverage 87.38% 87.47% +0.08%
==========================================
Files 86 86
Lines 13825 13912 +87
==========================================
+ Hits 12081 12169 +88
+ Misses 1744 1743 -1
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bigtable backend ignored the
ByteRangeparameter inget_tiered_object(the parameter was named_range), returning the full object with noContentRangeregardless of what the client requested. This meant clients always received 200 with the complete payload instead of 206 Partial Content.Adds an
apply_rangehelper that resolves the byte range against the payload and produces a zero-copyBytes::slice, then wires it into theget_tiered_objectreturn path.