Repository navigation
feat(dashboard): Show conversation archive and action errors as toasts - #2781
Merged
Merged
Conversation
Co-Authored-By: Thomas Jiang <20501235+thomasjiangcy@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c9f2410. Configure here.
Contributor
|
11 screenshot changes — 11 changed · 0 added · 0 removed Review screenshots in Frameshift |
Co-Authored-By: Thomas Jiang <20501235+thomasjiangcy@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
thomasjiangcy
approved these changes
Nov 6, 2026
23 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The "Conversation archived" undo card and the row-action error cards were a hand-rolled
Noticewith its own timer and fixed positioning. Both the home list and the sidebar had their own copy of it. The dashboard already mounts the shadcnToaster(Base UI), and the automation and workspace pages already use it. This PR moves the conversation notices onto it.useConversationActionToastsshows the undo toast, the archive/restore/pin error toasts, and clears an error when a later action on the same conversation succeeds. The home list and the sidebar both use it, so the copied notice code,ConversationArchiveNotices.tsx, and the now-unusedNoticecomponent are deleted.MutationObserver, with options pulled out asarchiveConversationMutationOptions. The toast can outlive the list that made it, so it can't depend on a mounted hook. It uses the same mutation key, so pending-archive readers still see the restore.ui/toast.tsx:ToastActionno longer getsactionPropsspread in, because Base UI already applies them and every action ran twice. Icons now sit at the top, in line with the title, likeAlert. Before, they were centered, so they drifted down when the text wrapped.E2E changes: low-priority toasts render as
dialog, notstatus. High-priority toasts arearia-hiddenand announced through a visually hiddenrole="alert", so the existingalertselectors still match.Known edge case, same as before this PR: if you archive another conversation while a restore is still running, the second undo toast closes when the first restore finishes.
via @thomasjiangcy.
--
View Session in Sentry