fix(pipedream): skip gate for single-region groups#97
Merged
Conversation
mchen-sentry
force-pushed
the
mingchen/skip-gate-single-region-groups
branch
from
02d344d to
5c889c3
Compare
When a group has one region there's nothing to filter, and services in that shape may override SENTRY_REGION per cell (uptime-checker-k8s, vector-uc-k8s) — in that case the gate compares the cell name against the group region and self-skips every cell job. Skip wrap_task entirely when std.length(regions) == 1. Multi-region groups (st) keep the gate. Updated single-region-multi-cell fixture to override SENTRY_REGION per cell, exercising the case.
mchen-sentry
force-pushed
the
mingchen/skip-gate-single-region-groups
branch
from
5c889c3 to
937f09f
Compare
kenzoengineer
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uptime-checkerdeploys are triggering our region-skip gate. Their groups have one region, butpipeline_fnfans out to physical cells that overrideSENTRY_REGIONper cell, so the region gate compares a cell name (us-east-sc) againstPIPEDREAM_GROUP_REGIONS=usand exits 0 on every cell.There's nothing to subset in a single-region group, so we skip the gate there. Multi-region groups (
st) keep it.The
single-region-multi-cellfixture now overridesSENTRY_REGIONper cell so it covers this.